New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon filenames #31

Closed
ctag opened this Issue Apr 23, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@ctag

ctag commented Apr 23, 2015

Hi,

I had to rename the icon to qtpass-icon.png for xdg-icon-resource install --size 128 artwork/qtpass-icon.png to run without complaining about improper naming format. I'm interested to know whether the icons should be kept generic in the project and renamed during build with something like a PKGBUILD for Archlinux.

Thanks,
ctag

@rdoeffinger

This comment has been minimized.

Contributor

rdoeffinger commented Apr 26, 2015

I assume the xdg-icon-resource is something that you did? Or does qmake add that automatically somewhere I couldn't find?
While I am not generally opposed to renaming, I expect the correct solution is to specifiy the optional icon-name parameter for xdg-icon-resource.

@ctag

This comment has been minimized.

ctag commented Apr 28, 2015

xdg-icon-resource is something I did manually after installing qtpass via the Archlinux AUR pkgbuild. I think it'll be easy enough to implement in a pkgbuild, but I wanted to mention that it is a thing. Thanks!

@ctag ctag closed this Apr 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment