New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font and spacing used for URL links on right in main window absurdly large #329

Closed
cfr42 opened this Issue Oct 29, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@cfr42

cfr42 commented Oct 29, 2017

In the main window, everything looks fine except that the font and spacing used for URLs on the right is ridiculously large. Only Pass is visible without scrolling and there is so much space I didn't initially realise there was anything to scroll to. The other interface elements (toolbar text and icons, contents of password store on left side etc.) are unaffected. Unlike the problems with the config dialogue, this issue doesn't block normal usage, but it is ugly and rather confusing at first. I assume that QtPass is ignoring system-wide font settings for the right hand pane, for some reason. However, I'm not sure about this - that's just what it looks like.

@annejan

This comment has been minimized.

Member

annejan commented Nov 7, 2017

Hi @cfr42 I can't seem to reproduce this on Mac, Windows or Linux (KDE and Cinnamon).

Could you make a screenshot, since I'm guessing from your previous issue #328 you are using KDE(5) plasma on Arch.
I'll give that combination a go (to reproduce this issue) as soon as I can manage to find some time.

Thanks in advance!

@annejan annejan added the ui / ux label Nov 7, 2017

@annejan

This comment has been minimized.

Member

annejan commented Nov 8, 2017

Does it look something like the examples in #278?

@hgraeber

This comment has been minimized.

Contributor

hgraeber commented Nov 16, 2017

I can confirm this. But what I observe is not similar to #278 and it happens with KDE under openSUSE Tumbleweed on a FullHD- and a HighDPI-Screen (Different machines). It started with 1.2.0, screenshot are below.

screenshot_qtpass
screenshot_qtpass-2

I fixed that issue myself with the following patch:

diff -up ./QtPass-1.2.0/main/main.cpp.highdpi ./QtPass-1.2.0/main/main.cpp
--- ./QtPass-1.2.0/main/main.cpp.highdpi        2017-11-08 21:55:04.000000000 +0100
+++ ./QtPass-1.2.0/main/main.cpp        2017-11-15 23:29:45.989065136 +0100
@@ -35,7 +35,8 @@
  * @return
  */
 int main(int argc, char *argv[]) {
-  qputenv("QT_AUTO_SCREEN_SCALE_FACTOR", "1");
+  QApplication::setAttribute(Qt::AA_EnableHighDpiScaling);
+
   QString text = "";
   for (int i = 1; i < argc; ++i) {
     if (i > 1)

   if (name.isEmpty())
@mdunc

This comment has been minimized.

mdunc commented Apr 11, 2018

I'm seeing the exact same thing as @hgraeber. Just hooked up my 4K monitor on openSuse Tumbleweed and qtpass is looking pretty awful - just like those screenshots.
image

@annejan, have you taken a look at that patch above?

@mdunc

This comment has been minimized.

mdunc commented Apr 12, 2018

I can confirm with the above patch, QtPass displays as expected. Thanks @hgraeber!
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment