New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline Editing #34

Closed
sjau opened this Issue Apr 26, 2015 · 9 comments

Comments

Projects
None yet
3 participants
@sjau

sjau commented Apr 26, 2015

Hi there

It's great that you added editing. However when I have entries with multilines there's only one line to edit - it will be saved again as multi-line... but for editing purposes it would also be good if that was multiline.

@annejan

This comment has been minimized.

Member

annejan commented Apr 30, 2015

The multi-line editing currently only works with Qt5.

Qt4 doesn't support programmatically spawning multi-line input popup.
We are planning on making it fully Qt4 compatible (by adding a separate .ui etc) when we add things like optional templates for username, URL etc.

@sjau

This comment has been minimized.

sjau commented May 1, 2015

What about QTextEdit? That's multiline for Qt4

@annejan

This comment has been minimized.

Member

annejan commented May 1, 2015

Yes, a multi-line widget. Which will need to be placed on a window etc.

the whole password add/edit popup is currently one line (of code), the multi-line version of that is not available in Qt4.

As soon as we start working on more edit features, we'll use a QTextEdit widget and be Qt4 compatible.

@sjau

This comment has been minimized.

sjau commented May 1, 2015

That would be great. I did start using multiline because double-click sometimes doesn't "select the whole word". Especially password with special chars get broken. So having them on a seperate line makes it easier to select

Anyway, like the new QtPass version quite a bit... the old version could only just display the passwords which was already great.

@rdoeffinger

This comment has been minimized.

Contributor

rdoeffinger commented May 2, 2015

I have to admit I personally just hoped the need to Qt4 support would go away before anyone cared about this feature enough. If you can reasonably compile against Qt 5.2 or newer I'd recommend that, if for no other reason that it's the only one I currently test against.

@annejan

This comment has been minimized.

Member

annejan commented May 2, 2015

I didn't notice the issue personally either until a co-worker compiled it on his mac.
Homebrew defaults to 4.8 still and apparently there are a lot of people still using Qt4 for some reason. I do test builds against Qt4 now but only sporadically.

@rdoeffinger

This comment has been minimized.

Contributor

rdoeffinger commented May 2, 2015

I suspect the reason for many is that e.g. installing qt-creator by default pulls in the Qt4 development environment. Others like users of Ubuntu LTS have a better reason (Qt5 isn't available in it), but maybe it would be worth recommending Qt5 in the documentation/README?

@sjau

This comment has been minimized.

sjau commented Jun 30, 2015

Well, multi-line editing works on Qt 5 :) thx for the support.

IMHO this can be closed/marked as solved.

@annejan

This comment has been minimized.

Member

annejan commented Jul 10, 2015

screen shot 2015-07-10 at 02 18 11

Now in develop branch. . QtPass now fully working on Qt 4.4 and later 👍

@annejan annejan closed this Jul 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment