Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows WebDAV broken by 24f8dec3c203921f765e923e6ae6a4069b8cf50a #36

Closed
rdoeffinger opened this issue May 2, 2015 · 6 comments
Closed

Windows WebDAV broken by 24f8dec3c203921f765e923e6ae6a4069b8cf50a #36

rdoeffinger opened this issue May 2, 2015 · 6 comments
Assignees

Comments

@rdoeffinger
Copy link
Contributor

@rdoeffinger rdoeffinger commented May 2, 2015

As MinGW is the only working way to compile for Windows AFAIK and even Mingw-w64 defines MINGW32 that commit completely breaks Windows WebDAV support.
In addition it does not even warn about the fact that it is not working, it just silently does nothing.
Could you please open a ticket or otherwise inform me if my changes introduce issues?
Preferably with information to reproduce, since as said MinGW (though the more modern -w64 variant) is what I test all code with.

@rdoeffinger
Copy link
Contributor Author

@rdoeffinger rdoeffinger commented May 2, 2015

Possibly all that is missing is a #include winnetwk.h

@rdoeffinger
Copy link
Contributor Author

@rdoeffinger rdoeffinger commented May 2, 2015

-lmpr might be necessary as well, if it doesn't come in some other way (e.g. via Qt).

@annejan
Copy link
Member

@annejan annejan commented May 2, 2015

I'm sorry for the breakage, and will try and handle such issues better in the future.

I wanted to quickly test windows builds and both on XP and 7 it failed directly.
After googling the awfully named WNetCancelConnection2A I came to the (wrong) conclusion that it was a Visual studio / Microsoft compiler thing and added the MINGW32 line which fixed the builds.

Will try build on a vanilla Windows VM with just QtCreator installed soon and when it works fine on that close this issue if that's alright with you.

@annejan annejan self-assigned this May 2, 2015
@rdoeffinger
Copy link
Contributor Author

@rdoeffinger rdoeffinger commented May 2, 2015

No worries, just tell me when I break things, that is a good idea either way. I admit I assumed I was the only one handling Windows anyway so I was a bit less careful with changes to it as long as it worked for me.
I am not sure "with just QtCreator installed" will work, I think MinGW needs to be installed separately, so that still leaves the choice between different versions that might not all work the same way.

@annejan
Copy link
Member

@annejan annejan commented May 3, 2015

Ah yeah, I meant the standard "community" installer, which if you just [next][next][finish] installs MinGW too. http://www.qt.io/download-open-source/

Will try this evening so I can close this issue.

@annejan
Copy link
Member

@annejan annejan commented May 3, 2015

Moved the mpr library inclusion from QMAKE_LFLAGS to LIBS += -lmpr 328eb82

Now works on bare minimum Windows Qt install again.

@annejan annejan closed this May 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.