Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny bit of regression #379

Closed
annejan opened this issue May 2, 2018 · 3 comments
Closed

Tiny bit of regression #379

annejan opened this issue May 2, 2018 · 3 comments

Comments

@annejan
Copy link
Member

@annejan annejan commented May 2, 2018

1 new defect(s) introduced to IJHack/qtpass found with Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)

** CID 277649: Uninitialized members (UNINIT_CTOR)
/src/trayicon.cpp: 35 in TrayIcon::TrayIcon(QMainWindow *)()


*** CID 277649: Uninitialized members (UNINIT_CTOR)
/src/trayicon.cpp: 35 in TrayIcon::TrayIcon(QMainWindow *)()
29 isAllocated = true;
30 } else {
31 dbg() << "No tray icon for this OS possibly also not show options?";
32
33 isAllocated = false;
34 }

CID 277649: Uninitialized members (UNINIT_CTOR)
Non-static class member "parentwin" is not initialized in this constructor nor in any functions that it calls.

35 }
36
37 /**
38 * @brief TrayIcon::setVisible show or hide the icon.
39 * @param visible
40 */

annejan added a commit that referenced this issue May 2, 2018
@FiloSpaTeam
Copy link
Contributor

@FiloSpaTeam FiloSpaTeam commented May 2, 2018

You can use this one :)
Q_UNUSED

@annejan annejan closed this in a26a98c May 2, 2018
@annejan
Copy link
Member Author

@annejan annejan commented May 2, 2018

Oww...
Next time I'll use Q_UNUSED instead of what I did now (moving the parentwin init to top of constructor and assigning nullptr to the rest of 'm ;)

@FiloSpaTeam
Copy link
Contributor

@FiloSpaTeam FiloSpaTeam commented May 2, 2018

Don't worry :) anyway the memory is freed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants