Boxes already checked for user in .gpg-id file

[kenji21]

We share password (and login) using passwordstore command and QtPass (thanks for this nice software) across our team
One limitation is that we can't easily know who can use password in which subfolder, let's say in this configuration

a.com/.gpg-id (3E286FDFD9232A11/userA 3F01457BC926AD78/userB)
a.com/login
b.com/.gpg-id (3E286FDFD9232A11/userA 46D6CAF30BFC2B4F/userC)
b.com/login

When clicking a.com, then "Users",
Actual:
no checkboxes are checked at all

Expected:
checkboxes of userA and userB should be checked, but not userC of course

Regards

[Alixerid]

This seems to be a symptom/duplicate of #205:
(On windows) the .gpg-id files in subfolders are ignored. When opening the dialog the checkboxes are filled with the permissions that are set by the .gpg-id in the root folder of the passwordstore only.

Has there been any progress with this issue? This problem with not parsing the .gpg-ids in subfolders is somewhat of a roadblock for using QtPass in teams (on Windows).

[Alixerid]

@annejan Thanks for tagging! I was wondering why you tagged this as regression. Was there a fix for this bug in a previous release? (Honest and humble question. Sorry, if it is a stupid one.)

I was trying to read the code and identify the problem. Since the bug only occurs on Windows, I was suspecting that it might either be an issue with Qt on Windows or it is something about file path specification (non-POSIX etc.) that interferes in the case distinction and iteration over folders and parent folders. Has anyone pinpointed the problem?

[kenji21]

I have this "bug" on macOS, maybe it can change something in the way you read the code

[annejan]

@Alixerid the reason for the regression tag is that it used to work, so somewhere while changing other stuff this broke.

This issue is something I am currently looking into, and hope to be able to pin down this week.

[Alixerid]

Thanks, @annejan, guess I hadn't realized that this worked before.
Sounds great that you are looking into it. Best of luck pinning it down!

[kenji21]

OK, we (with @NitroG42) found the issue, the gpg command is called with ""3F01457BC926AD78" "46D6CAF30BFC2B4F"" as one single string argument, which make it listing no users with these keys, exemple:

$ gpg --no-tty --with-colons --list-keys  ""3F01457BC926AD78" "46D6CAF30BFC2B4F""
gpg: error reading key: No public key
tru::1:1525247596:0:3:1:5

while it works when adding each keys as separate arguments.

Can I make a PR with this commit which fixes this issue : openium@0ba1d54 ?

[annejan]

Thank you for investigating and fixing, yes, a PR would be very welcome @kenji21

[kenji21]

There it is: PR #403

[annejan]

Tested and merged