Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Prevent from removing whole password-store directory and hidden directories and files #400
Clicking Delete button when there is no focus on any treeview item (when opening QtPass or clicking on already selected item, etc) will lead to complete removing of password-store directory including .git repository, so there will be no way to restore password-store if you don't have backups or remote origin.
QtPass version 1.2.3
Hi @SergeyBear I'm trying to reproduce this . . but the red X delete button gets disabled as soon as I don't have focus on any file or folder and the right click context menu doesn't show delete either in those cases for me . . on macOS at-least.
Can you help me reproduce this error?
Hello @annejan !
Found annother issue with focus:
To reproduce: create two passwordstores Test1 and Test2. Select item on Test1 and switch to Test2 and press Create button on toolbar - it will offer to create item on Test1 onstead of Test2.
OS: Fedora 27/28 (all packages uptodate)
added a commit
Aug 18, 2018
I was more thinking of things like refusing to delete files/directories starting with ".", refusing to delete non-empty directories (at least without extra confirmation), refusing anything that isn't actually below the password store repo or similar measures...