You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Util::normalizeFolderPath is changed to only
!path.endsWith(QDir::separator())
instead of before
!path.endsWith("/") && !path.endsWith(QDir::separator())
I think that is less correct. Other changes are possibly problematic as well
A few relevant facts:
'/' is a perfectly valid path separator in Windows since at least XP (I think even in Win98 or so).
Paths with / is the normalized Qt representation independent of OS semantics.
As such IMHO I think / should always be supported, and it might make more sense to support \ by having Qt normalize the paths (via e.g. QDir::fromNativeSeparators)
The text was updated successfully, but these errors were encountered:
Serves me right for trying my hand at windows "fixes" without having used windows in the last 10 or so years ;)
Merged your changes and will have a play with a windows VM later on some rainy day . .
Util::normalizeFolderPath is changed to only
!path.endsWith(QDir::separator())
instead of before
!path.endsWith("/") && !path.endsWith(QDir::separator())
I think that is less correct. Other changes are possibly problematic as well
A few relevant facts:
As such IMHO I think / should always be supported, and it might make more sense to support \ by having Qt normalize the paths (via e.g. QDir::fromNativeSeparators)
The text was updated successfully, but these errors were encountered: