New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory separator actually broken by 208171fd09c55ad765fdf4fa1de9a7f0757fa72d #53

Closed
rdoeffinger opened this Issue Jun 14, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@rdoeffinger
Contributor

rdoeffinger commented Jun 14, 2015

Util::normalizeFolderPath is changed to only
!path.endsWith(QDir::separator())
instead of before
!path.endsWith("/") && !path.endsWith(QDir::separator())
I think that is less correct. Other changes are possibly problematic as well
A few relevant facts:

  1. '/' is a perfectly valid path separator in Windows since at least XP (I think even in Win98 or so).
  2. Paths with / is the normalized Qt representation independent of OS semantics.
    As such IMHO I think / should always be supported, and it might make more sense to support \ by having Qt normalize the paths (via e.g. QDir::fromNativeSeparators)
@annejan

This comment has been minimized.

Member

annejan commented Jun 14, 2015

Serves me right for trying my hand at windows "fixes" without having used windows in the last 10 or so years ;)
Merged your changes and will have a play with a windows VM later on some rainy day . .

annejan added a commit that referenced this issue Jun 15, 2015

@annejan

This comment has been minimized.

Member

annejan commented Jun 15, 2015

Reverted the removal of the (in most cases) double check ;)
e5f845e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment