Skip to content

Directory separator actually broken by 208171fd09c55ad765fdf4fa1de9a7f0757fa72d #53

@rdoeffinger

Description

@rdoeffinger

Util::normalizeFolderPath is changed to only
!path.endsWith(QDir::separator())
instead of before
!path.endsWith("/") && !path.endsWith(QDir::separator())
I think that is less correct. Other changes are possibly problematic as well
A few relevant facts:

  1. '/' is a perfectly valid path separator in Windows since at least XP (I think even in Win98 or so).
  2. Paths with / is the normalized Qt representation independent of OS semantics.
    As such IMHO I think / should always be supported, and it might make more sense to support \ by having Qt normalize the paths (via e.g. QDir::fromNativeSeparators)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions