New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the clipboard logic to allow for on-demand copy to clipboard. #119

Merged
merged 2 commits into from Nov 22, 2015

Conversation

Projects
None yet
2 participants
@jonhanks
Contributor

jonhanks commented Nov 21, 2015

Sometimes I want secondary information from a entry (URL, notes, ...) and don't always want the password being pushed to the clipboard. So I added a new state to the clipboard handling, copy on-demand.

For the UI I changed the clipboard config entry to be a combobox instead of a checkbox. It has 3 states:

  • Never copy to the clipboard
  • Always copy to the clipboard
  • On-demand copy to the clipboard

Added a 'Password' button to the main window which copies the password to the clipboard when pressed.
The button is disabled when there is no password loaded or passwords are set to never copy to the clipboard.

Added a context menu entry to the text browser to copy the password to the clipboard.

Moved some of the clipboard code around to make it more flexible. Clippedpass is always set when the password could be copied.

jonhanks and others added some commits Nov 21, 2015

Modified the clipboard logic to allow for on-demand copy to clipboard.
Changed the clipboard config entry to be a combobox instead of a checkbox.  It has 3 states:
Never copy to the clipboard
Always copy to the clipboard
On-demand copy to the clipboard

Added a 'Password' button to the main window which copies the password to the clipboard when pressed.
The button is disabled when there is no password loaded or passwords are set to never copy to the clipboard.

Added a context menu entry to the text browser to copy the password to the clipboard.

Moved some of the clipboard code around to make it more flexible.  Clippedpass is always set when the password could be copied.
Jonathan Hanks
Some tweaks to make the linthub check happier. Most removing whitespa…
…ce and keeping line lengths under 80 chars.

This does not address all of the linthub warnings.  It targets code I modified for the on-demand-clipboard branch
and ignores the inconsistancies of where the open brace should be for methods as that varies through the code base.
@annejan

This comment has been minimized.

Member

annejan commented Nov 22, 2015

Thanks for the effort.
This looks and feels like a very useful addition.

annejan added a commit that referenced this pull request Nov 22, 2015

Merge pull request #119 from jonhanks/on-demand-clipboard
Modified the clipboard logic to allow for on-demand copy to clipboard.

@annejan annejan merged commit ff072d1 into IJHack:master Nov 22, 2015

2 of 3 checks passed

linthub Linthub has found some code style suggestions while reviewing the pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

annejan added a commit that referenced this pull request Jun 1, 2016

Merge pull request #119 from jonhanks/on-demand-clipboard
Modified the clipboard logic to allow for on-demand copy to clipboard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment