Modified the clipboard logic to allow for on-demand copy to clipboard. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the clipboard config entry to be a combobox instead of a checkbox. It has 3 states: Never copy to the clipboard Always copy to the clipboard On-demand copy to the clipboard Added a 'Password' button to the main window which copies the password to the clipboard when pressed. The button is disabled when there is no password loaded or passwords are set to never copy to the clipboard. Added a context menu entry to the text browser to copy the password to the clipboard. Moved some of the clipboard code around to make it more flexible. Clippedpass is always set when the password could be copied.
…ce and keeping line lengths under 80 chars. This does not address all of the linthub warnings. It targets code I modified for the on-demand-clipboard branch and ignores the inconsistancies of where the open brace should be for methods as that varies through the code base.
|
Thanks for the effort. |
annejan
added a commit
that referenced
this pull request
Nov 22, 2015
Modified the clipboard logic to allow for on-demand copy to clipboard.
annejan
added a commit
that referenced
this pull request
Jun 1, 2016
Modified the clipboard logic to allow for on-demand copy to clipboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Sometimes I want secondary information from a entry (URL, notes, ...) and don't always want the password being pushed to the clipboard. So I added a new state to the clipboard handling, copy on-demand.
For the UI I changed the clipboard config entry to be a combobox instead of a checkbox. It has 3 states:
Added a 'Password' button to the main window which copies the password to the clipboard when pressed.
The button is disabled when there is no password loaded or passwords are set to never copy to the clipboard.
Added a context menu entry to the text browser to copy the password to the clipboard.
Moved some of the clipboard code around to make it more flexible. Clippedpass is always set when the password could be copied.