Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows-related fixes. #17

Merged
merged 17 commits into from Mar 29, 2015
Merged

Windows-related fixes. #17

merged 17 commits into from Mar 29, 2015

Conversation

@rdoeffinger
Copy link
Contributor

@rdoeffinger rdoeffinger commented Mar 29, 2015

The patches I sent as issues before as pull request.

rdoeffinger added 5 commits Mar 29, 2015
Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
There will be no finish() event in that case.
This can happen if the program to start does not
exist or has wrong permissions.

Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
This makes the program work on Windows.

Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
…PIN.

Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
A bit quick-and-dirty, but it seems to work.
Note: The usePass variant is not properly tested.

Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
@rdoeffinger
Copy link
Contributor Author

@rdoeffinger rdoeffinger commented Mar 29, 2015

Sorry, was too lazy to create branches. This pull request now also contains edit/insert/delete feature implementation.
If you prefer I can make a branch with only the Windows fixes.

rdoeffinger added 12 commits Mar 29, 2015
This fixes failures if the name contains spaces.

Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
Makes it easier and more reliable to use.

Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
This is useful for use from a USB stick.

Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
It is used to set the GNUPGHOME environment variable.
This allows to specify the GnuPG configuration and
keyring location, especially for use on USB stick.

Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
@annejan
Copy link
Member

@annejan annejan commented Mar 29, 2015

Adding now, will replace popups with multiline edit (for password) and merge ..

annejan added a commit that referenced this pull request Mar 29, 2015
Windows-related fixes.
Basic editing and adding.
@annejan annejan merged commit bdf482a into IJHack:master Mar 29, 2015
@rdoeffinger
Copy link
Contributor Author

@rdoeffinger rdoeffinger commented Mar 30, 2015

Thanks!
Just to make sure you didn't miss it: Since bbbdbe4 the password input dialog is multi-line if you use Qt 5.2 or later.
So there should be no need to replace it unless you want to fully support earlier versions (I kept the single line edit as fallback since I wasn't sure dropping support for such recent versions was reasonable).

@annejan
Copy link
Member

@annejan annejan commented Mar 30, 2015

Ah yes, noticed it later on my main laptop (with up-to-date Qt).
In the develop branch I have made some changes last month which I would like to intergrate that used the multi-line field used for viewing, for editing too.
So I might still change the editing to a smoother (no popup) experience ;)
Thanks for your work, this has gotten me back into working on this project some more too :)

@rdoeffinger
Copy link
Contributor Author

@rdoeffinger rdoeffinger commented Mar 30, 2015

Just for reference, I had (besides lazyness of course ;) ) a few half-good reasons not to use the existing field.
For example I felt that it is fairly overloaded already, since both errors, error messages and decrypted output end up in there. This seems particularly bad when the editing/adding/encrypting failed and you need to display the error in the same thing where you just entered the text...
Then specifically for editing, there is a bit of complex interaction with the clipboard features that remove e.g. the password. Would you when editing ignore that setting and display the full text?
Also some people might want an option to never show passwords, with the dialog it is fairly simple to just pop it up twice and ask to enter the same thing.
I'm sure it's quite possible to come up with something better than I implemented, it just felt like it might have to come with a bigger redesign of the interface.
Btw: one small thing I noticed: "pass" seems to add an extra newline at the end of the passwords, and it clearly assumes it to exist when it prints the value. I don't really like that behaviour, but it might make sense to align qtpass with that anyway....

@annejan annejan self-assigned this Mar 30, 2015
annejan added a commit that referenced this pull request Jun 1, 2016
Windows-related fixes.
Basic editing and adding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.