New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase maximum password length to 255 #209

Merged
merged 1 commit into from Oct 17, 2016

Conversation

Projects
None yet
2 participants
@vladimiroff
Contributor

vladimiroff commented Oct 17, 2016

QSpinBox has a default maximum of 99 thus making it impossible to
generate longer passwords.

http://doc.qt.io/qt-5/qspinbox.html#maximum-prop

Increase maximum password length to 255
QSpinBox has a default maximum of 99 thus making it impossible to
generate longer passwords.
@annejan

This comment has been minimized.

Member

annejan commented Oct 17, 2016

Thank you very much for this addition.

I'll also add this change to the (new) QSpinBox in the password add/edit dialog.

@annejan annejan merged commit d005546 into IJHack:master Oct 17, 2016

4 checks passed

Snap CI The Snap CI build passed on Oct 17, 2016!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
linthub Linthub has cleared the pull request, no code style suggestions found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment