Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a copy button for each line to paste the content into the clipboard, "pass init -- path=" command with right path-parameter, lupdate qtpass.pro #218

Merged
merged 5 commits into from Nov 17, 2016

Conversation

@YoshiMan
Copy link

@YoshiMan YoshiMan commented Nov 16, 2016

Now we have the possibility to copy the additional-information from the password-file into the clipboard.
Maybe thats not the right QT-way, feel free to correct this. Im new on QT and it works. :)
See attached screenshot. e.g on doubleclick will the username or the url be pasted into the clipboard and be cleared after the amount of the configured autoclear.
enabledoubleclicktocopyintoclipboard

The pass init command, which was executed, when you add new users to the password files, was executed full qualified. e.g. pass init --path=/home/user/mypassstore/DBpasswords ... , and the password store is locate under /home/user/mypassstore. This would result into a new folder into the password storage /home/user/mypassstore/home/user/mypassstore/DBpasswords, because pass init --path=... sees its path-parameter relativ to the passstore.
see mainwindow.cpp:1485
unfortunately no extra commit :( sry

I also executed the lupdate qtpass.pro command to re-generate the *.ts files. Now they are in sync with the code again.

@jounathaen
Copy link
Member

@jounathaen jounathaen commented Nov 16, 2016

Nice, I wanted to have something simmilar.
Suggestion: Don't copy on doubleclick on the lable, but add a small copy button at the end of each line.
I think this would be easier to understand for other users.

@YoshiMan
Copy link
Author

@YoshiMan YoshiMan commented Nov 16, 2016

Would be a nice idea too.
But the, we should move the "copy password"-button down there too, right?
And i would place at the begining of the line, not the end. So its closer to the left panel, where you last clicked.

@jounathaen
Copy link
Member

@jounathaen jounathaen commented Nov 16, 2016

Totally agree!
I'd imagine a small Button with a copy icon, that fits at the beginning of the line or something like that. No big text...

@YoshiMan
Copy link
Author

@YoshiMan YoshiMan commented Nov 16, 2016

okay. hopefully i will be able to push it today.

layout changes from formlayout to gridlayout
@YoshiMan
Copy link
Author

@YoshiMan YoshiMan commented Nov 16, 2016

so i pushed it, but the button image is just the :/icons/go-top.svg. Please change it :)
And please heavy test this feature ;)

Janosch Knack
@jounathaen
Copy link
Member

@jounathaen jounathaen commented Nov 16, 2016

Can you upload a screenshot? I can currently not merge?

@YoshiMan
Copy link
Author

@YoshiMan YoshiMan commented Nov 16, 2016

I'll upload it tomorrow morning. Just found the way to my bed ;) its 00:10 in germany :P

@YoshiMan
Copy link
Author

@YoshiMan YoshiMan commented Nov 17, 2016

Good morning (for me). Here are the screenshots.
The copy password button is gone, but each line got its own one. (of course still the wrong image).

showpassword notemplate showcontent
showpasswordnotemplateshowcontent
showpassword usetemplate showcontent
showpasswordusetemplateshowcontent
hidecontent
hidecontent
hidepassword usetemplate showcontent
hidepasswordusetemplateshowcontent
hidepassword notemplate showcontent
hidepasswordnotemplateshowcontent

@YoshiMan YoshiMan changed the title enable doubleklick on label to paste the content into the clipboard, "pass init -- path=" command with right path-parameter, lupdate qtpass.pro added a copy button for each line to paste the content into the clipboard, "pass init -- path=" command with right path-parameter, lupdate qtpass.pro Nov 17, 2016
@annejan
Copy link
Member

@annejan annejan commented Nov 17, 2016

Good morning . .
Awesome work @YoshiMan

Would you like me to merge this pull request and fix the icons and check on all behaviours . .
Or would you like to continue with this pull request some more?

@YoshiMan
Copy link
Author

@YoshiMan YoshiMan commented Nov 17, 2016

Pls merge and heavy test :)
We can open new issus, if have some more work with this feature.

@annejan annejan merged commit 3f2b18a into IJHack:master Nov 17, 2016
4 checks passed
4 checks passed
Snap CI The Snap CI build passed on Nov 16, 2016!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
linthub Linthub has cleared the pull request, no code style suggestions found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.