New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for editing .gpg-id via GUI with public keyring list. #23

Merged
merged 1 commit into from Apr 14, 2015

Conversation

Projects
None yet
2 participants
@rdoeffinger
Contributor

rdoeffinger commented Apr 4, 2015

This is not really a pull request since it does nothing useful.
But i don't know a better idea to make sure people are aware, and give a chance to comment early on.
I've been working a bit on making a user-interface to edit the .gpg-id file.
What I managed so far is creating a dialog with a list of all public keys and checkboxes for them.
The next step would be to read in an existing .gpg-id, set checkboxes according to that, add extra entries if a public key for a user is not available and after the dialog exits writing a new .gpg-id file.
There is a bit of a user-interface issue though, as the current UI makes it look as it is editable per-file, plus I'd prefer to not add code to change all existing files.

@rdoeffinger rdoeffinger force-pushed the rdoeffinger:useredit branch 2 times, most recently from 1ea8b43 to c3fd48c Apr 6, 2015

@rdoeffinger

This comment has been minimized.

Contributor

rdoeffinger commented Apr 6, 2015

While some of the issues I pointed out still exist (and yes, the usability really isn't any good), the code now works and I think it works well enough.
One known issue: if there are keys in the .gpg-id that aren't in the public key-ring I suspect bad things might happen. I have not yet tested it.
There are likely to be a few more issues like that, though I think it is already useful.

@rdoeffinger rdoeffinger changed the title from [FYI/RFC] Editing .gpg-id to Support for editing .gpg-id via GUI with public keyring list. Apr 6, 2015

User edit dialog for modifying .gpg-id added.
Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>

@rdoeffinger rdoeffinger force-pushed the rdoeffinger:useredit branch from c3fd48c to 4d43c77 Apr 11, 2015

annejan added a commit that referenced this pull request Apr 14, 2015

Merge pull request #23 from rdoeffinger/useredit
Support for editing .gpg-id via GUI with public keyring list.

@annejan annejan merged commit e8a8abb into IJHack:master Apr 14, 2015

annejan added a commit that referenced this pull request Jun 1, 2016

Merge pull request #23 from rdoeffinger/useredit
Support for editing .gpg-id via GUI with public keyring list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment