New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start process only after we finished disabling UI elements etc. #24

Merged
merged 1 commit into from Apr 14, 2015

Conversation

Projects
None yet
2 participants
@rdoeffinger
Contributor

rdoeffinger commented Apr 11, 2015

Otherwise we have a race condition, e.g. if the binary does not
exist the error signal might be triggered before we disabled
the UI element.
This would mean that we end up with UI elements being permanently
disabled.

Signed-off-by: Reimar Döffinger Reimar.Doeffinger@gmx.de

Start process only after we finished disabling UI elements etc.
Otherwise we have a race condition, e.g. if the binary does not
exist the error signal might be triggered before we disabled
the UI element.
This would mean that we end up with UI elements being permanently
disabled.

Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>

annejan added a commit that referenced this pull request Apr 14, 2015

Merge pull request #24 from rdoeffinger/bugfix_start_error
Start process only after we finished disabling UI elements etc.

@annejan annejan merged commit 491fa0f into IJHack:master Apr 14, 2015

@rdoeffinger rdoeffinger deleted the rdoeffinger:bugfix_start_error branch Apr 15, 2015

annejan added a commit that referenced this pull request Jun 1, 2016

Merge pull request #24 from rdoeffinger/bugfix_start_error
Start process only after we finished disabling UI elements etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment