Start process only after we finished disabling UI elements etc. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we have a race condition, e.g. if the binary does not exist the error signal might be triggered before we disabled the UI element. This would mean that we end up with UI elements being permanently disabled. Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
annejan
added a commit
that referenced
this pull request
Apr 14, 2015
Start process only after we finished disabling UI elements etc.
annejan
added a commit
that referenced
this pull request
Jun 1, 2016
Start process only after we finished disabling UI elements etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we have a race condition, e.g. if the binary does not
exist the error signal might be triggered before we disabled
the UI element.
This would mean that we end up with UI elements being permanently
disabled.
Signed-off-by: Reimar Döffinger Reimar.Doeffinger@gmx.de