New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of qpushbuttonwithclipboard and timers #241

Merged
merged 3 commits into from Nov 27, 2016

Conversation

Projects
None yet
2 participants
@tezeb
Contributor

tezeb commented Nov 26, 2016

Fixed memleaks in qpushbuttowithclipboard and refactored a bit to remove dependency from MainWindow. Only signal-based comunication right now.
Also fixed panel timer, which apparently was not working, as well as added member timer for clipboard clearing(there was an issue, that when clicked "copy pass" multiple times, clipboard was cleared multiple times, thus the last copied pass was not kept there as long as expected).

tezeb added some commits Nov 26, 2016

fix Panel and Pass timers
  - make Panel timer non dyn-allocated, with fixed config and working(it was not)
  - add Pass timer as member, with fixed config

@annejan annejan merged commit e62ebad into IJHack:master Nov 27, 2016

3 of 4 checks passed

Snap CI The Snap CI build failed on Nov 26, 2016!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
linthub Linthub has cleared the pull request, no code style suggestions found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment