New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process management refactoring part 2 #249

merged 5 commits into from Dec 5, 2016


None yet
2 participants

tezeb commented Dec 5, 2016

Further extraction of process managment. It seems to work both with pass and natively. Tested only on Linux though. Mostly moving code around, but also added new interfaces.
As previously I tried to split it into logical(somehow) parts.

  1. 6353745 Initial interface of process executor
  2. c464f6e I allowed myself to add some more info to debug logs(in ugliest possible way, sorry), but it shows file/linenumber now, which speeds up looking for debugs/issues.
  3. aa0eb00 This is ready executor, which I am using in half baked part 3 of refactoring(with few minor changes).
  4. b11e71d Switch everything possible to use new executor, to hide PM from application.
  5. lang update ofc

Next steps:

  1. change MW<->Pass communication to multiple signals (for each action type(see PROCESS enum inside Pass)).
  2. add "transactions" - I've noticed that especially with native programs, if there is an error with first execution, the error is hidden from view, as it's replaced with results of further executions. It's hard to reproduce and probably does not happen very often, but it will allow for better error handling. What do you think?

tezeb added some commits Nov 28, 2016


This comment has been minimized.


annejan commented Dec 5, 2016

Awesome work .. this will make debugging some of the current issues a lot easier 👍

@annejan annejan merged commit 11d563a into IJHack:master Dec 5, 2016

3 of 4 checks passed

Snap CI The Snap CI build failed on Dec 05, 2016!
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
linthub Linthub has cleared the pull request, no code style suggestions found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment