New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executeing pass show before editpassword dialog shows up #254

Merged
merged 3 commits into from Dec 11, 2016

Conversation

Projects
None yet
2 participants
@YoshiMan

YoshiMan commented Dec 11, 2016

Double-clicking might open previous entry instead of one double-clicked on #243

Janosch Knack added some commits Dec 11, 2016

Janosch Knack
executeing pass show before editpassword dialog shows up
Double-clicking might open previous entry instead of one double-clicked on #243
Janosch Knack
executeing pass show before editpassword dialog shows up
Double-clicking might open previous entry instead of one double-clicked on #243
@YoshiMan

This comment has been minimized.

YoshiMan commented Dec 11, 2016

While working on this ticket, this lastDecrypt property was very confusing for me. Do we really need it?
Should it be removed? I think we could handle this with the signal/slot concept?

Janosch Knack
some CI fixes
changed override to Q_DECL_OVERRIDE
changed nullptr to Q_NULLPTR
@annejan

This comment has been minimized.

Member

annejan commented Dec 11, 2016

I think lastDecrypt is/was only needed to check weather or not the clipboard should be cleared . .
But that might be able to be done within the signal/slot concept too by giving the clear clipboard scheduled call the data to check/clear . .

We don't want to clear the clipboard if it doesn't contain the password (or something else from our app) but the user has copied something else . .

@annejan annejan added the refactoring label Dec 11, 2016

@annejan annejan merged commit c88b9f2 into IJHack:master Dec 11, 2016

3 of 4 checks passed

Snap CI (app) The Snap CI build failed on Dec 11, 2016!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
linthub Linthub has cleared the pull request, no code style suggestions found.
Details
@YoshiMan

This comment has been minimized.

YoshiMan commented Dec 11, 2016

hm. i think its the MainWindow::clippedText, you are talking about. This one handles the clipboard related stuff.

@annejan

This comment has been minimized.

Member

annejan commented Dec 11, 2016

Yep .. so we could/should probably completely refactor out the lastDecrypt stuff . .

That's still a remnant from when QtPass was a simple read-only pass viewer for management ;)

@YoshiMan YoshiMan deleted the YoshiMan:feature/#243 branch Dec 11, 2016

@YoshiMan

This comment has been minimized.

YoshiMan commented Dec 11, 2016

Alright. I'll open an Issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment