New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: CTRL/CMD + Q closes the mainwindow #258 #259

Merged
merged 1 commit into from Dec 14, 2016

Conversation

Projects
None yet
2 participants
@YoshiMan

YoshiMan commented Dec 14, 2016

enabled shortcut
extra treatment for mc os

Janosch Knack
Feature: CTRL/CMD + Q closes the mainwindow #258
enabled shortcut
extra treatment for mc os
@YoshiMan

This comment has been minimized.

YoshiMan commented Dec 14, 2016

please test under Mac OS

@annejan annejan self-assigned this Dec 14, 2016

@annejan

This comment has been minimized.

Member

annejan commented Dec 14, 2016

Travis-CI will fail on macOS when it finally gets to that @YoshiMan ;)

http://doc.qt.io/qt-5/qkeysequence.html#qt_set_sequence_auto_mnemonic
Note: This function is not declared in any of Qt's header files.
To use it in your application, declare the function prototype before calling it.

But it is available via on 4.8 . .

To test I added to mainwindow.h (before the namespace and class stuff)

#ifdef __APPLE__
#if QT_VERSION >= QT_VERSION_CHECK(5, 0, 0)
// http://doc.qt.io/qt-5/qkeysequence.html#qt_set_sequence_auto_mnemonic
void qt_set_sequence_auto_mnemonic(bool b);
#endif
#endif

Unfortunately this change does nothing for me since Cmd+Q already closes the app on macOS 😁

But I also tested on Windows VM and seems to work fine . .

@YoshiMan

This comment has been minimized.

YoshiMan commented Dec 14, 2016

Yeah. It would be better, if you could fix this. Thank you.

@annejan annejan merged commit 6cab167 into IJHack:master Dec 14, 2016

2 of 4 checks passed

Snap CI (app) The Snap CI build failed on Dec 14, 2016!
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
linthub Linthub has cleared the pull request, no code style suggestions found.
Details

@YoshiMan YoshiMan deleted the YoshiMan:feature/#258-CTRL-CMD-Q-closes-the- branch Dec 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment