Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pwgen and refactor Pass::finished #271

Merged
merged 2 commits into from Jan 9, 2017
Merged

Fix pwgen and refactor Pass::finished #271

merged 2 commits into from Jan 9, 2017

Conversation

@tezeb
Copy link
Contributor

@tezeb tezeb commented Jan 9, 2017

Fix for #262.
Also "revert' fix for break added in switch. It was unreadable, sorry for that. I hope it's better now.

tezeb added 2 commits Jan 9, 2017
@annejan
annejan approved these changes Jan 9, 2017
@annejan
annejan approved these changes Jan 9, 2017
Copy link
Member

@annejan annejan left a comment

Way better, and it seems my interpretation of the CI notification might have broken the previous iteration.

Thanks for these fixes!

@annejan annejan merged commit 6759fc6 into IJHack:master Jan 9, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
linthub Linthub has cleared the pull request, no code style suggestions found.
Details
@tezeb
Copy link
Contributor Author

@tezeb tezeb commented Jan 9, 2017

On the bright side you made me update it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants