It's an extension to fix from one of my commits in previous pull request.
I properly hid password, but as it showed up, other fields where still visible duplicated when showing template fields.
It was supposed to be separate pull request. But as there is not that many changes, it can go as one.
So, this is final step in refactoring process management(except for unit tests and bugfixing).
The idea is that normal pass behaviour is what we want from ImitatePass, thus I've added transaction mechanism inside it. Now MainWindow is signaled only when pass-like action is complete. Previously all processes where signaling MainWindow, which made QtPass behave differently when using RealPass vs ImitatePass. All comunication is also done via dedicated signals(one signal per pass-like action), which makes it easy to extend MainWindow reactions.
From now on any differences in behaviour(when using different backends) shall be treated as a bug. Also it is assumed that any file names passed to Pass interface are in pass style, as MainWindow shall not care(nor check) which backend is in use.
I plan on adding some unit tests, to verify that both backends have exactly the same behaviour/interactions/signaling.
tezeb
changed the title
another attempt at fixing line duplication when displaying
Final step in process mgmt refactoring
Jan 10, 2017
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.
It's an extension to fix from one of my commits in previous pull request.
I properly hid password, but as it showed up, other fields where still visible duplicated when showing template fields.