New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final step in process mgmt refactoring #275

merged 8 commits into from Jan 11, 2017


None yet
2 participants

tezeb commented Jan 9, 2017

It's an extension to fix from one of my commits in previous pull request.
I properly hid password, but as it showed up, other fields where still visible duplicated when showing template fields.

tezeb added some commits Jan 9, 2017


This comment has been minimized.


tezeb commented Jan 10, 2017

It was supposed to be separate pull request. But as there is not that many changes, it can go as one.

So, this is final step in refactoring process management(except for unit tests and bugfixing).
The idea is that normal pass behaviour is what we want from ImitatePass, thus I've added transaction mechanism inside it. Now MainWindow is signaled only when pass-like action is complete. Previously all processes where signaling MainWindow, which made QtPass behave differently when using RealPass vs ImitatePass. All comunication is also done via dedicated signals(one signal per pass-like action), which makes it easy to extend MainWindow reactions.
From now on any differences in behaviour(when using different backends) shall be treated as a bug. Also it is assumed that any file names passed to Pass interface are in pass style, as MainWindow shall not care(nor check) which backend is in use.
I plan on adding some unit tests, to verify that both backends have exactly the same behaviour/interactions/signaling.

@tezeb tezeb changed the title from another attempt at fixing line duplication when displaying to Final step in process mgmt refactoring Jan 10, 2017


This comment has been minimized.


tezeb commented Jan 10, 2017

I skipped lupdate to ease code review.

@annejan annejan merged commit d6eb88d into IJHack:master Jan 11, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
linthub Linthub has cleared the pull request, no code style suggestions found.

This comment has been minimized.


annejan commented Jan 11, 2017

I've also ran these changes through coverity static code analyser

Thanks for the great work (again) @tezeb !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment