New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sftp, ftps, webdav and webdavs as supported links #322

Merged
merged 1 commit into from Oct 11, 2017

Conversation

Projects
None yet
3 participants
@cgonzalez
Contributor

cgonzalez commented Oct 11, 2017

Tested in KDE Plasma with Dolphin.

(Perhaps it could be better if QtPass allowed to define the supported link types.)

@annejan annejan self-requested a review Oct 11, 2017

@annejan

Looks good 👍

@annejan

This comment has been minimized.

Member

annejan commented Oct 11, 2017

The type definition is something for a future feature.

I was looking into changing the RegularExpressions into VerbalExpressions too . .

@annejan annejan merged commit d674481 into IJHack:master Oct 11, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
linthub Linthub has cleared the pull request, no code style suggestions found.
Details
@coveralls

This comment has been minimized.

coveralls commented Oct 11, 2017

Coverage Status

Coverage remained the same at 1.814% when pulling 31b6844 on cgonzalez:master into b2aa118 on IJHack:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Oct 11, 2017

Coverage Status

Coverage remained the same at 1.814% when pulling 31b6844 on cgonzalez:master into b2aa118 on IJHack:master.

@codecov

This comment has been minimized.

codecov bot commented Oct 11, 2017

Codecov Report

Merging #322 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #322   +/-   ##
======================================
  Coverage    2.93%   2.93%           
======================================
  Files          36      36           
  Lines        2690    2690           
  Branches      364     364           
======================================
  Hits           79      79           
  Misses       2610    2610           
  Partials        1       1
Impacted Files Coverage Δ
src/mainwindow.cpp 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2aa118...31b6844. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment