Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract static library and separate main function #324

Merged
merged 4 commits into from Oct 24, 2017
Merged

Conversation

@tezeb
Copy link
Contributor

@tezeb tezeb commented Oct 23, 2017

This commits separates main and rest of the code. Main is then used to created QtPass, using rest of the code compiled into static library. The same static library can now be directly linked with unit-tests, so there is no longer need to add separate object files for each test.
Common options moved from *.pro to qtpass.pri.

@annejan
Copy link
Member

@annejan annejan commented Oct 23, 2017

Wow, thanks!
This is a much needed cleanup, will look into the Windows build issue tomorrow.

@codecov
Copy link

@codecov codecov bot commented Oct 23, 2017

Codecov Report

Merging #324 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #324   +/-   ##
======================================
  Coverage    2.93%   2.93%           
======================================
  Files          36      36           
  Lines        2690    2690           
  Branches      364     358    -6     
======================================
  Hits           79      79           
  Misses       2610    2610           
  Partials        1       1
Impacted Files Coverage Δ
main/main.cpp 0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c78677...c3b5b26. Read the comment docs.

@tezeb tezeb force-pushed the tezeb:master branch from 464efc8 to 70c16db Oct 23, 2017
@coveralls
Copy link

@coveralls coveralls commented Oct 23, 2017

Coverage Status

Coverage decreased (-0.03%) to 1.783% when pulling 9157e82 on tezeb:master into 7c78677 on IJHack:master.

1 similar comment
@coveralls
Copy link

@coveralls coveralls commented Oct 23, 2017

Coverage Status

Coverage decreased (-0.03%) to 1.783% when pulling 9157e82 on tezeb:master into 7c78677 on IJHack:master.

@tezeb tezeb force-pushed the tezeb:master branch from 70c16db to 378868f Oct 24, 2017
@coveralls
Copy link

@coveralls coveralls commented Oct 24, 2017

Coverage Status

Coverage decreased (-0.03%) to 1.783% when pulling 464efc8 on tezeb:master into 7c78677 on IJHack:master.

1 similar comment
@coveralls
Copy link

@coveralls coveralls commented Oct 24, 2017

Coverage Status

Coverage decreased (-0.03%) to 1.783% when pulling 464efc8 on tezeb:master into 7c78677 on IJHack:master.

@coveralls
Copy link

@coveralls coveralls commented Oct 24, 2017

Coverage Status

Coverage decreased (-0.03%) to 1.783% when pulling 70c16db on tezeb:master into 7c78677 on IJHack:master.

@coveralls
Copy link

@coveralls coveralls commented Oct 24, 2017

Coverage Status

Coverage decreased (-0.03%) to 1.783% when pulling 378868f on tezeb:master into 7c78677 on IJHack:master.

1 similar comment
@coveralls
Copy link

@coveralls coveralls commented Oct 24, 2017

Coverage Status

Coverage decreased (-0.03%) to 1.783% when pulling 378868f on tezeb:master into 7c78677 on IJHack:master.

@coveralls
Copy link

@coveralls coveralls commented Oct 24, 2017

Coverage Status

Coverage increased (+0.004%) to 1.817% when pulling c3b5b26 on tezeb:master into 7c78677 on IJHack:master.

@annejan
Copy link
Member

@annejan annejan commented Oct 24, 2017

Fixed last mac issue, merging . .
Will look into windows issue(s) when I get to office and can spin up a Windows VM

@annejan annejan merged commit c3b5b26 into IJHack:master Oct 24, 2017
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
linthub Linthub has cleared the pull request, no code style suggestions found.
Details
@tezeb
Copy link
Contributor Author

@tezeb tezeb commented Oct 26, 2017

Thanks for fixing it. I hoped to at least fix the Windows issue, but get carried away. Will set up env and try to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants