Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New scroll bar on large files #347

Merged
merged 1 commit into from Jan 15, 2018
Merged

New scroll bar on large files #347

merged 1 commit into from Jan 15, 2018

Conversation

@destanyol
Copy link
Contributor

@destanyol destanyol commented Jan 11, 2018

Changed the style of the scroll bar when the text file containing the password is larger than usual.
I have never used Qt and I am on Linux KDE so I don't know if the change is global.

newscroll oldscroll

Changed the style of the scroll bar when the text file containing the password is larger than usual.
@annejan
Copy link
Member

@annejan annejan commented Jan 12, 2018

Works on macOS . . well..

screen shot 2018-01-12 at 02 00 12 Before

screen shot 2018-01-12 at 02 01 00 After

screen shot 2018-01-12 at 02 18 07When hovering

screen shot 2018-01-12 at 02 18 11After clicking

This seems to be completely ignoring your styling and taking native rendering for some reason.

@codecov
Copy link

@codecov codecov bot commented Jan 12, 2018

Codecov Report

Merging #347 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #347   +/-   ##
======================================
  Coverage    2.92%   2.92%           
======================================
  Files          36      36           
  Lines        2698    2698           
  Branches      360     360           
======================================
  Hits           79      79           
  Misses       2618    2618           
  Partials        1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad455b4...5da03c4. Read the comment docs.

@coveralls
Copy link

@coveralls coveralls commented Jan 12, 2018

Coverage Status

Coverage decreased (-0.0004%) to 1.776% when pulling 5da03c4 on destanyol:patch-1 into ad455b4 on IJHack:master.

1 similar comment
@coveralls
Copy link

@coveralls coveralls commented Jan 12, 2018

Coverage Status

Coverage decreased (-0.0004%) to 1.776% when pulling 5da03c4 on destanyol:patch-1 into ad455b4 on IJHack:master.

@annejan annejan merged commit affce86 into IJHack:master Jan 15, 2018
5 checks passed
5 checks passed
codecov/patch Coverage not affected when comparing ad455b4...5da03c4
Details
codecov/project 2.92% remains the same compared to ad455b4
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
linthub Linthub has cleared the pull request, no code style suggestions found.
Details
@lukedirtwalker
Copy link
Contributor

@lukedirtwalker lukedirtwalker commented Mar 12, 2018

This change changed the background of file content to white. Was that intended? I liked it more how it was previously.

@destanyol
Copy link
Contributor Author

@destanyol destanyol commented Mar 12, 2018

Ouch it's true, on my Linux it didn't change. I will take a look when I have some spare time.
I'm sorry...

@jounathaen
Copy link
Member

@jounathaen jounathaen commented Mar 13, 2018

I'm really not an expert on this, but my first guess would be, that you only have to remove these lines from the commit:

+             setStyleSheet(QString::fromUtf8(QScrollBar:vertical {              
+              border: 1px solid #999999;
+              background:white;
+              width:10px;    
+              margin: 0px 0px 0px 0px;
+             }
@destanyol
Copy link
Contributor Author

@destanyol destanyol commented May 11, 2018

Sorry I forgot about this...
Today I have tried to solve the changes on the background color but I have never used QT before and I have failed. I'm so sorry...
I have created a new pull request reverting the changes done here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants