Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #360

Merged
merged 6 commits into from Mar 26, 2018
Merged

Refactoring #360

merged 6 commits into from Mar 26, 2018

Conversation

@lukedirtwalker
Copy link
Contributor

@lukedirtwalker lukedirtwalker commented Mar 15, 2018

Introduce the FileContent class for parsing the password file and use it where we parsed manually before. Also slightly change the behavior of MainWindow how it shows the content (see commit for more details).

Like this it easier to re-find the content we are interested in.
This can be used to parse the content of the password file in a common
place. In a later commit we should replace the parsing in mainwindow and
passworddialog.
This also changes the behavior of the main window:
If content should be hidden nothing is shown.
Else the password is always shown as a field (either with hidden with
dots or openly visibly.) the rest is shown as plain text or as field
depending on the template settings.

This is results in a nicer ui and needs one translation (Password
hidden) less.
@coveralls
Copy link

@coveralls coveralls commented Mar 15, 2018

Coverage Status

Coverage increased (+4.5%) to 6.284% when pulling 81f93a2 on lukedirtwalker:refactoring into 0e427be on IJHack:master.

Loading

@coveralls
Copy link

@coveralls coveralls commented Mar 15, 2018

Coverage Status

Coverage increased (+4.5%) to 6.291% when pulling 827a710 on lukedirtwalker:refactoring into 0e427be on IJHack:master.

Loading

@codecov
Copy link

@codecov codecov bot commented Mar 15, 2018

Codecov Report

Merging #360 into master will increase coverage by 3.45%.
The diff coverage is 38.12%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #360      +/-   ##
=========================================
+ Coverage    2.92%   6.38%   +3.45%     
=========================================
  Files          36      39       +3     
  Lines        2698    2695       -3     
  Branches      361     351      -10     
=========================================
+ Hits           79     172      +93     
+ Misses       2618    2517     -101     
- Partials        1       6       +5
Impacted Files Coverage Δ
src/userinfo.h 0% <ø> (ø)
src/configdialog.h 0% <ø> (ø) ⬆️
src/pass.h 50% <ø> (ø) ⬆️
src/usersdialog.h 0% <ø> (ø) ⬆️
src/mainwindow.h 0% <ø> (ø) ⬆️
src/qtpasssettings.h 0% <ø> (ø) ⬆️
src/mainwindow.cpp 0% <0%> (ø) ⬆️
src/qtpasssettings.cpp 2.81% <0%> (-0.14%) ⬇️
src/configdialog.cpp 0% <0%> (ø) ⬆️
src/filecontent.h 100% <100%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e427be...827a710. Read the comment docs.

Loading

* Split datahelpers.h to userinfo.h and passwordconfiguration.h
* Rename passwordConfiguration to PasswordConfiguration
* Move some code to separate methods in MainWindow
* Handle PasswordConfiguration in QtPassSettings and in ConfigDialog
@lukedirtwalker
Copy link
Contributor Author

@lukedirtwalker lukedirtwalker commented Mar 22, 2018

Hi @annejan any chance for a review? Sorry for stressing ;)

Loading

@annejan annejan merged commit 6dedcc2 into IJHack:master Mar 26, 2018
5 checks passed
Loading
@annejan
Copy link
Member

@annejan annejan commented Mar 26, 2018

I'm sorry I didn't have time earlier . .

Hope you have not planted a red-herring I might have missed, but it all looks good to me 👯‍♂️

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants