New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #300 #363

Merged
merged 3 commits into from Apr 9, 2018

Conversation

Projects
None yet
3 participants
@FiloSpaTeam
Contributor

FiloSpaTeam commented Apr 4, 2018

Now before folder deletion, check if there are unexpected files and warn the user.

@codecov

This comment has been minimized.

codecov bot commented Apr 4, 2018

Codecov Report

Merging #363 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #363      +/-   ##
=========================================
- Coverage    6.38%   6.34%   -0.04%     
=========================================
  Files          39      39              
  Lines        2695    2710      +15     
  Branches      351     355       +4     
=========================================
  Hits          172     172              
- Misses       2517    2532      +15     
  Partials        6       6
Impacted Files Coverage Δ
src/mainwindow.h 0% <ø> (ø) ⬆️
src/mainwindow.cpp 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd33d9c...64ddef2. Read the comment docs.

@coveralls

This comment has been minimized.

coveralls commented Apr 4, 2018

Coverage Status

Coverage decreased (-0.02%) to 6.266% when pulling 64ddef2 on UnitooTeam:master into bd33d9c on IJHack:master.

@coveralls

This comment has been minimized.

coveralls commented Apr 4, 2018

Coverage Status

Coverage decreased (-0.01%) to 6.277% when pulling 04c7c89 on UnitooTeam:master into bd33d9c on IJHack:master.

@FiloSpaTeam

This comment has been minimized.

Contributor

FiloSpaTeam commented Apr 5, 2018

I added a new QAction to open folder directly from QtPass using QDesktopServices

@annejan annejan merged commit ef9349a into IJHack:master Apr 9, 2018

4 of 6 checks passed

codecov/patch 0% of diff hit (target 6.38%)
Details
codecov/project 6.34% (-0.04%) compared to bd33d9c
Details
CodeFactor No issues found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
linthub Linthub has cleared the pull request, no code style suggestions found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment