Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizations :) #367

Merged
merged 8 commits into from Apr 25, 2018
Merged

Optimizations :) #367

merged 8 commits into from Apr 25, 2018

Conversation

@FiloSpaTeam
Copy link
Contributor

@FiloSpaTeam FiloSpaTeam commented Apr 24, 2018

First of all i refactored QtPassSettings itself.
Later i cleaned up some business logic about PasswordDialog in MainWindow.

Should run faster now :)

FiloSpaTeam added 8 commits Apr 23, 2018
Update
@coveralls
Copy link

@coveralls coveralls commented Apr 24, 2018

Coverage Status

Coverage decreased (-0.1%) to 6.073% when pulling c18bf18 on UnitooTeam:master into f04322c on IJHack:master.

1 similar comment
@coveralls
Copy link

@coveralls coveralls commented Apr 24, 2018

Coverage Status

Coverage decreased (-0.1%) to 6.073% when pulling c18bf18 on UnitooTeam:master into f04322c on IJHack:master.

@codecov
Copy link

@codecov codecov bot commented Apr 24, 2018

Codecov Report

Merging #367 into master will decrease coverage by 0.3%.
The diff coverage is 7.16%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #367      +/-   ##
=========================================
- Coverage    6.37%   6.07%   -0.31%     
=========================================
  Files          39      39              
  Lines        2713    2700      -13     
  Branches      355     347       -8     
=========================================
- Hits          173     164       -9     
+ Misses       2534    2530       -4     
  Partials        6       6
Impacted Files Coverage Δ
src/mainwindow.h 0% <ø> (ø) ⬆️
src/mainwindow.cpp 0% <0%> (ø) ⬆️
src/qtpasssettings.h 0% <0%> (ø) ⬆️
src/qtpasssettings.cpp 0.9% <0.45%> (-1.91%) ⬇️
src/settingsconstants.cpp 98.03% <100%> (ø) ⬆️
src/passworddialog.cpp 58.06% <37.5%> (-16.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f04322c...c18bf18. Read the comment docs.

@annejan annejan self-requested a review Apr 25, 2018
@annejan annejan merged commit 13dab84 into IJHack:master Apr 25, 2018
6 checks passed
6 checks passed
CodeFactor 2 issues fixed.
Details
codecov/patch 7.16% of diff hit (target 6.37%)
Details
codecov/project Absolute coverage decreased by -0.3% but relative coverage increased by +0.79% compared to f04322c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
linthub Linthub has cleared the pull request, no code style suggestions found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.