Small refactoring.#378
Merged
annejan merged 6 commits intoIJHack:masterfrom May 2, 2018
UnitooTeam:master
Merged
Conversation
…manual static_cast to int for Enums::ClipboardType
Updating local repo
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
========================================
+ Coverage 6.48% 6.5% +0.02%
========================================
Files 39 39
Lines 2591 2582 -9
Branches 341 337 -4
========================================
Hits 168 168
+ Misses 2417 2408 -9
Partials 6 6
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thinking over this question: What the MainWindow should know about the others instances? For example, should know if SystemTrayIsAvailable before instance TrayIcon? I think no. So i changed this appending a new bool member to check if TrayIcon isAllocated.
I purged check about something is NULL before delete. Delete itself does this check internally :)
About config checking i think that should be done before start MainWindow itself. In some way this should run once right?