Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring. #378

Merged
merged 6 commits into from May 2, 2018
Merged

Small refactoring. #378

merged 6 commits into from May 2, 2018

Conversation

FiloSpaTeam
Copy link
Contributor

I thinking over this question: What the MainWindow should know about the others instances? For example, should know if SystemTrayIsAvailable before instance TrayIcon? I think no. So i changed this appending a new bool member to check if TrayIcon isAllocated.

I purged check about something is NULL before delete. Delete itself does this check internally :)

About config checking i think that should be done before start MainWindow itself. In some way this should run once right?

@annejan annejan self-requested a review May 1, 2018 15:53
@codecov
Copy link

codecov bot commented May 1, 2018

Codecov Report

Merging #378 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #378      +/-   ##
========================================
+ Coverage    6.48%   6.5%   +0.02%     
========================================
  Files          39     39              
  Lines        2591   2582       -9     
  Branches      341    337       -4     
========================================
  Hits          168    168              
+ Misses       2417   2408       -9     
  Partials        6      6
Impacted Files Coverage Δ
src/qtpasssettings.h 0% <ø> (ø) ⬆️
src/trayicon.h 0% <ø> (ø) ⬆️
src/configdialog.h 0% <ø> (ø) ⬆️
src/keygendialog.cpp 0% <0%> (ø) ⬆️
src/qtpasssettings.cpp 0.92% <0%> (-0.01%) ⬇️
src/trayicon.cpp 0% <0%> (ø) ⬆️
src/mainwindow.cpp 0% <0%> (ø) ⬆️
src/configdialog.cpp 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca8aa87...1fdc1ef. Read the comment docs.

@coveralls
Copy link

coveralls commented May 1, 2018

Coverage Status

Coverage decreased (-0.04%) to 6.316% when pulling 1fdc1ef on UnitooTeam:master into ca8aa87 on IJHack:master.

@annejan annejan merged commit c60f302 into IJHack:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants