New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OTP code generation on Linux as requested in #327 #394

Merged
merged 10 commits into from May 25, 2018

Conversation

Projects
None yet
3 participants
@Noettore
Contributor

Noettore commented May 15, 2018

I've added support for pass-otp extension on Linux as requested in #327.

The configdialog now has an option to activate OTP code generation that happens pressing the button in the menu bar after selecting an entry. If the entry password is an otp url the code is generated, shown in the mainwindow and copied in the clipboard, otherwise an error is shown.

On windows and apple the option in the configdialog is hidden as well as the button.
In imitatepass the OtpGenerate method is currently empty.
I've already writted an otp library but for now I do not know how to integrate it in imitatePass. Is there a way to get the password of an entry so that I can pass it to the library for the otp code generation?

Noettore added some commits May 7, 2018

Started integrating pass otp plugin
Signed-off-by: Ettore Dreucci <ettore.dreucci@gmail.com>
OTP button calls external pass otp -c
Signed-off-by: Ettore Dreucci <ettore.dreucci@gmail.com>
Added checkbox for otp plugin in config dialog. Some problems with si…
…gnal finishedOtpShow: ui hang

Signed-off-by: Ettore Dreucci <ettore.dreucci@gmail.com>
Added OTP handler. Now ui doesn't hang any more.
Signed-off-by: Ettore Dreucci <ettore.dreucci@gmail.com>
OTP is shown and copied to clipboard automatically. If compiled on WI…
…N and APPLE OTP button and options are hidden.

Signed-off-by: Ettore Dreucci <ettore.dreucci@gmail.com>
Typo
Signed-off-by: Ettore Dreucci <ettore.dreucci@gmail.com>
Fixed wrong numeration in configdialog.ui
Signed-off-by: Ettore Dreucci <ettore.dreucci@gmail.com>
Added OTP lib for imitatepass
Signed-off-by: Ettore Dreucci <ettore.dreucci@gmail.com>
Removed libotp. Further thinking required to integrate OTP generation…
… in imitatePass.

Signed-off-by: Ettore Dreucci <ettore.dreucci@gmail.com>
@coveralls

This comment has been minimized.

coveralls commented May 15, 2018

Coverage Status

Coverage decreased (-0.08%) to 6.351% when pulling 85f3b3b on Noettore:feature/otp into eea0c7d on IJHack:master.

Removed blank lines
Signed-off-by: Ettore Dreucci <ettore.dreucci@gmail.com>
@codecov

This comment has been minimized.

codecov bot commented May 15, 2018

Codecov Report

Merging #394 into master will decrease coverage by 0.04%.
The diff coverage is 2.94%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #394      +/-   ##
=========================================
- Coverage     6.5%   6.45%   -0.05%     
=========================================
  Files          39      39              
  Lines        2553    2571      +18     
=========================================
  Hits          166     166              
- Misses       2387    2405      +18
Impacted Files Coverage Δ
src/mainwindow.h 0% <ø> (ø) ⬆️
src/pass.h 50% <ø> (ø) ⬆️
src/configdialog.h 0% <ø> (ø) ⬆️
src/imitatepass.h 25% <ø> (ø) ⬆️
src/realpass.h 100% <ø> (ø) ⬆️
src/qtpasssettings.h 0% <ø> (ø) ⬆️
src/mainwindow.cpp 0% <0%> (ø) ⬆️
src/qtpasssettings.cpp 0.91% <0%> (-0.01%) ⬇️
src/pass.cpp 2.6% <0%> (+0.06%) ⬆️
src/imitatepass.cpp 0.47% <0%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eea0c7d...85f3b3b. Read the comment docs.

@annejan annejan merged commit cc29730 into IJHack:master May 25, 2018

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
CodeFactor 1 issue found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
linthub Linthub has cleared the pull request, no code style suggestions found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment