New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dutch (nl) translation improvements #418

Merged
merged 4 commits into from Sep 25, 2018

Conversation

Projects
None yet
3 participants
@equaeghe

equaeghe commented Sep 13, 2018

No description provided.

Erik Quaeghebeur added some commits Sep 12, 2018

Erik Quaeghebeur
Unify nl_BE and nl_NL localization files
There was essentially no difference between these two variants.
So it would be a hassle to maintain both separately.
The difference there was (Seconden vs. Secondes) is not even
one that is a substantive difference between BE and NL. Both
are used in both regions and both are correct.
Erik Quaeghebeur
Correct and improve Dutch translations
The Dutch translations contained some errors and some translations
that deviated substantially from the original. This change corrects
errors and makes some changes. The focus was on keeping the
translations close to the original and use terminology consistently.
(In case the originals are actually worse descriptions, it is those
that should be changed first, before it is propagated to the
translations.)
@equaeghe

This comment has been minimized.

equaeghe commented Sep 13, 2018

Hmm, I just realized that also the qtpass.pro and qtpass.qrc files probably also need to be updated. I'll hold off from doing that until I get some feedback, as there may be other things I've missed.

@coveralls

This comment has been minimized.

coveralls commented Sep 13, 2018

Coverage Status

Coverage increased (+0.1%) to 6.5% when pulling e77dce9 on equaeghe:nl-vertalingverbeteringen into b4dc9e6 on IJHack:master.

@annejan

This comment has been minimized.

Member

annejan commented Sep 13, 2018

I think those are the only needed changes, although I will have to see if the language loader works like this since I think it's based on language_COUNTRY (like the nl_NL, nl_BE etc).
Will probably have time to play with this tomorrow.

@equaeghe

This comment has been minimized.

equaeghe commented Sep 13, 2018

I think those are the only needed changes,

I searched through the source files for nl_NL and only the desktop file also needed some attention.

although I will have to see if the language loader works like this since I think it's based on language_COUNTRY (like the nl_NL, nl_BE etc).

Hmm, I hope it works (should've tested it myself, sorry); for ‘ca’ (Catalan?) there is also no country code given currently.

Will probably have time to play with this tomorrow.

Ok, let me know if I need to fix something.

@annejan annejan merged commit 4fe1a73 into IJHack:master Sep 25, 2018

4 checks passed

CodeFactor No issues found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
linthub Linthub has cleared the pull request, no code style suggestions found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment