Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use key fingerprint as ID instead of “long” ID. #452

Merged
merged 1 commit into from Apr 17, 2019

Conversation

Projects
None yet
3 participants
@Natureshadow
Copy link
Contributor

commented Apr 16, 2019

It is generally assumed that for applications demanding good security, the full key fingerprint should be used instead of just the 64-bit or, let alone, 32-bit key ID.

This PR uses the key fingerprint from GPG to replace the key ID. It works by waiting for an fpr record in the key list and, if it looks like belonging to the key at hand by comparing the end of the fingerprint to the previously found ID, replacing the key_id field with it (it should normally be the next line after the pub or sec record).

As a bonus, this increases compatibility with other frontends, like gopass-pw, which use the fingerprint and would cause unwanted updates of .gpg-id.

@coveralls

This comment has been minimized.

Copy link

commented Apr 16, 2019

Coverage Status

Coverage decreased (-0.003%) to 7.151% when pulling 255f6e2 on Natureshadow:gpg-use-fpr into 1ad0648 on IJHack:master.

@codecov

This comment has been minimized.

Copy link

commented Apr 16, 2019

Codecov Report

Merging #452 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #452      +/-   ##
=========================================
- Coverage    7.23%   7.23%   -0.01%     
=========================================
  Files          41      41              
  Lines        2722    2724       +2     
=========================================
  Hits          197     197              
- Misses       2525    2527       +2
Impacted Files Coverage Δ
src/pass.cpp 4.61% <0%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ad0648...255f6e2. Read the comment docs.

@annejan annejan merged commit 3698ff0 into IJHack:master Apr 17, 2019

3 of 5 checks passed

codecov/patch 0% of diff hit (target 7.23%)
Details
codecov/project 7.23% (-0.01%) compared to 1ad0648
Details
CodeFactor No issues found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.