Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing finishedShow() signal connection in PasswordDialog constructor (fixes the "Edit password" function) #473

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@maciejsszmigiero
Copy link
Contributor

maciejsszmigiero commented Sep 8, 2019

Commit 990b89c ("Removed unused headers from mainwindow.cpp. Disable UseTrayIcon if it's not available for the OS.")
moved Pass finishedShow() signal connection for a PasswordDialog from
MainWindow::setPassword() to the (first) PasswordDialog constructor.

However PasswordDialog has actually two constructors, and the second one
needs to make this connection, too, otherwise the "Edit password" function
does not load the edited entry data.

See:
#423
#465
#470

…uctor

Commit 990b89c ("Removed unused headers from mainwindow.cpp. Disable UseTrayIcon if it's not available for the OS.")
moved Pass finishedShow() signal connection for a PasswordDialog from
MainWindow::setPassword() to the (first) PasswordDialog constructor.

However PasswordDialog has actually two constructors, and the second one
needs to make this connection, too, otherwise the "Edit password" function
does not load the edited entry data.

See:
#423
#465
#470
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 8, 2019

Coverage Status

Coverage decreased (-0.02%) to 6.95% when pulling b42dc5d on maciejsszmigiero:passworddialog-finishedshow-fix into 87217d3 on IJHack:master.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 8, 2019

Codecov Report

Merging #473 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #473      +/-   ##
=========================================
- Coverage    7.33%   7.32%   -0.01%     
=========================================
  Files          44      44              
  Lines        2796    2798       +2     
=========================================
  Hits          205     205              
- Misses       2591    2593       +2
Impacted Files Coverage Δ
src/passworddialog.cpp 58.09% <0%> (-1.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87217d3...b42dc5d. Read the comment docs.

@annejan annejan merged commit 553b64c into IJHack:master Sep 9, 2019
3 of 5 checks passed
3 of 5 checks passed
codecov/patch 0% of diff hit (target 7.33%)
Details
codecov/project 7.32% (-0.01%) compared to 87217d3
Details
CodeFactor No issues found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@annejan annejan mentioned this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.