Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Main window entry details improvements #477
This PR contains two main window entry details improvements:
Also included here is a commit that removes an unused signal and an unused function from
QtPass::connectPassSignalHandlers() will be called twice, the first time for the real pass and the second time for a pass imitator. This means that we can't connect MainWindow::passShowHandlerFinished signal in this function or it will be connected (and so then invoked) twice. Connect it in the QtPass::connectPassSignalHandlers() single caller instead.
Commit 3cb140c ("Trying to use QtPass as process handler and connector for Pass") removed a DisplayInTextBrowser() call from MainWindow::passShowHandler() and added a similar QtPass::showInTextBrowser() function that is invoked by QtPass::passShowHandlerFinished() slot. This slot is in turn connected to MainWindow::passShowHandlerFinished signal which wasn't emitted anywhere in the code. Emit it where the old DisplayInTextBrowser() call was so password entry non-template details are actually displayed upon selecting it in the main QtPass window.
…window Knowing the TOTP secret for a password entry allows somebody to recreate the whole OTP sequence so it definitely shouldn't be displayed in the clear. In fact, it shouldn't be displayed at all in the main window since the proper way to utilize a TOTP entry is to click the "OTP" button to generate a new OTP (rather than to copy the secret to the clipboard like it was a password). The password edit dialog isn't affected by this change and will still show the whole entry, including its TOTP secret if present.
@@ Coverage Diff @@ ## master #477 +/- ## ========================================= + Coverage 7.3% 7.46% +0.16% ========================================= Files 44 44 Lines 2806 2812 +6 ========================================= + Hits 205 210 +5 - Misses 2601 2602 +1