Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't call QtPass::setup() from QtPass class constructor (should fix #466) #482
QtPass::setup() cannot be called from this class constructor as it
It looks like this was introduced in commit bc19f9e.
Rename QtPass::setup() to QtPass::init() and call it explicitly at the end
Should fix #466, but the whole thing
The QtPass class is not usable without a MainWindow object so it can as well take it directly as its constructor parameter.
QtPass::setup() cannot be called from this class constructor as it possibly calls back MainWindow::config() method. QtPass constructor is in turn called from the MainWindow one so the MainWindow object might not be fully constructed yet. It looks like this was introduced in commit bc19f9e. Rename QtPass::setup() to QtPass::init() and call it explicitly at the end of the MainWindow constructor. Should fix #466, but the whole thing really needs a refactoring to establish a clear QtPass -> MainWindow (or MainWindow -> QtPass) relationship and to make sure there aren't any circular dependencies there (and other similar bugs).
@@ Coverage Diff @@ ## master #482 +/- ## ====================================== Coverage 7.15% 7.15% ====================================== Files 44 44 Lines 2851 2851 ====================================== Hits 204 204 Misses 2647 2647