Swedish localization#5
Merged
Merged
Conversation
annejan
added a commit
that referenced
this pull request
Apr 26, 2026
Reproduced via SIGSEGV on a fresh-config launch: #0 QLineEdit::selectAll() #1 MainWindow::focusInput() #2 ... (timer event) #3 QEventLoop::exec() ← nested loop from QDialog::exec() #4 ConfigDialog::wizard() #5 MainWindow::config() #6 QtPass::init() #7 MainWindow::MainWindow() `MainWindow`'s constructor was scheduling `QTimer::singleShot(10, this, SLOT(focusInput()))` *before* calling `m_qtPass->init()`. On a fresh install (no `.gpg-id`/invalid config), `init()` calls `MainWindow::config()` which runs the first-run wizard via `QDialog::exec()` — i.e. a nested event loop. The 10 ms timer fires inside that loop while the main window has not yet been shown, `focusInput()` runs, and `QLineEdit::selectAll()` crashes inside Qt because the line-edit's owning top-level isn't visible/realized yet. Move the timer scheduling to *after* `init()` returns successfully, and bail out of the constructor early when init fails. The success path is unchanged for normal launches; the wizard path no longer queues the focus pulse during the nested loop, and the failure path no longer queues it before destruction.
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Swedish labels and tested in Qt Linguist.