Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 86 clear panel #87

Merged
merged 2 commits into from Aug 6, 2015
Merged

Issue 86 clear panel #87

merged 2 commits into from Aug 6, 2015

Conversation

@karlgrz
Copy link

@karlgrz karlgrz commented Aug 6, 2015

Implemented a "Autoclear panel" checkbox and corresponding duration control in the Config tab.

qtpass_config

Then, when the duration has passed, the content panel is cleared, like so:

qtpass_cleared

I also updated .gitignore for the artifacts generated from building on ubuntu (I was just running qmake && make in the qtpass root and then running the binary generated like ./qtpass if there's a better, cleaner way let me know.

@annejan
Copy link
Member

@annejan annejan commented Aug 6, 2015

Wow, thanks, that's fast :)

Will give it a quick one-over and add Dutch and German translations for it

I was never really bothererd by the artifacts (on OSX or Arch), but it's also a good addition to the .gitignore

I don't think there is really a cleaner way to do things.

@annejan
Copy link
Member

@annejan annejan commented Aug 6, 2015

Looks great on first viewing and reading the diffs (on mobile)

You also made me uncover an inconsistency that slipped in using the autoclear value for the hide on start. Thanks :)

@annejan annejan merged commit 9ce775d into IJHack:master Aug 6, 2015
2 of 3 checks passed
2 of 3 checks passed
Snap CI The Snap CI build failed on Aug 06, 2015!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
linthub Linthub has cleared the pull request, no code style suggestions found.
Details
@karlgrz
Copy link
Author

@karlgrz karlgrz commented Aug 6, 2015

Double bonus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants