New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit of password broken with active "Automatically push" #177

Closed
juergenthomann opened this Issue May 14, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@juergenthomann

juergenthomann commented May 14, 2016

If I try to change an existing password, it doesn't show anything of the saved data and the password field contains "Already up-to-date."

Version is 1.1.1 (openSUSE rpm)

@annejan

This comment has been minimized.

Member

annejan commented May 14, 2016

The "Already up-to-date" looks like a git notification for some reason ended up as the decrypted password.
Does viewing password work without an issue?

@juergenthomann

This comment has been minimized.

juergenthomann commented May 14, 2016

viewing works fine for me

@annejan

This comment has been minimized.

Member

annejan commented May 17, 2016

Installing openSUSE to try and reproduce this bug..

@annejan annejan added bug Linux labels May 17, 2016

@juergenthomann

This comment has been minimized.

juergenthomann commented May 21, 2016

I looked now a bit into the code and I'm not sure how this exactly works but I added some debugging stuff that may can help you.

I added a debug output in MainWindow::readyRead

+  qDebug() << "Current Action: " << currentAction;
   QString error = process->readAllStandardError();
   if (currentAction != GPG_INTERNAL) {
     output = process->readAllStandardOutput();
+    qDebug() << output;

The result without pull:

Current Action: 0
"\nlogin:\n"

With pull enabled:

Current Action: 0
"Already up-to-date.\n"
Current Action: 0
"\nlogin:\n"

Interesting is the result when I press the pull button manually:

Current Action: 1
"Already up-to-date.\n"

I solved this problem when I changed MainWindow::editPassword:

   if (useGit && autoPull)
     on_updateButton_clicked();
   waitFor(30);
+  process->waitForFinished();
   // TODO(annejan) move to editbutton stuff possibly?
   currentDir = getDir(ui->treeView->currentIndex(), false);

So more it looks a bit like a race condition here for me. If you like to have some more debug output or other changes, just let me know.

@annejan annejan closed this in 55ff570 Jun 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment