New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System Icons on Buttons and Doubleclick on treeView #124

Merged
merged 21 commits into from Jan 22, 2016

Conversation

Projects
None yet
4 participants
@jounathaen
Member

jounathaen commented Dec 17, 2015

The Buttons "Add", "User", ... are now drawn with the system theme default icons and I added some spacing. (looks good on cinnamon 2.8)
Also I added the functionality that a double-click on a item opens the edit window.
Best regards
Jonathan

@jounathaen jounathaen closed this Dec 19, 2015

@annejan annejan reopened this Dec 19, 2015

@annejan

This comment has been minimized.

Member

annejan commented Dec 19, 2015

I'll try this on OSX and Windows as soon as I can.
Works like a charm and looks great on KDE Arch..

@jounathaen

This comment has been minimized.

Member

jounathaen commented Dec 19, 2015

Okay, i've closed the pull request as i got trouble on gnome and now my
whole qt installation crashed. But when it works: great :-)
Best regards
Jonathan

Am 19. Dezember 2015 01:16:04 schrieb Anne Jan Brouwer
notifications@github.com:

I'll try this on OSX and Windows as soon as I can.
Works like a charm and looks great on KDE Arch..


Reply to this email directly or view it on GitHub:
#124 (comment)

@jounathaen

This comment has been minimized.

Member

jounathaen commented Dec 19, 2015

Okay, does work. Forget about the last Message

@jounathaen

This comment has been minimized.

Member

jounathaen commented Dec 21, 2015

Ok, i'll keep coding some stuff until someone stops me :-D

jounathaen added some commits Dec 22, 2015

Deletes Folders Properly
Message when creating a Folder shows absolute path
@annejan

This comment has been minimized.

Member

annejan commented Dec 27, 2015

Double click on folders should just open them, will fix tomorrow but won't merge to 1.6 yet.

Also looking into OSX and Windows icons.

@jounathaen jounathaen force-pushed the jounathaen:master branch 2 times, most recently from 34830be to 0a16974 Dec 31, 2015

@annejan

This comment has been minimized.

Member

annejan commented Jan 12, 2016

I'm going to try and cherry-pick these changes into a new branch . .

@jounathaen

This comment has been minimized.

Member

jounathaen commented Jan 18, 2016

Great! the major changes would be: Icons on Buttons, Dropdown on Add Button (folder or file) and the config layout. The Icons from Термитоz look nice on KDE, I'm looking forward to see them on some other Desktop environment!

@annejan

This comment has been minimized.

Member

annejan commented Jan 18, 2016

The problem with the graphics is that we are currently unsure about compatibility with the GPL
But the re-design (buttons to the left) of the main screen looks very good to me.

@termitoz

This comment has been minimized.

termitoz commented Jan 18, 2016

I replaced the icons for free-icons + replaced progressbar for coolest animated gif. You can see the changes in my branch: https://github.com/termitoz/qtpass/tree/futurator-redesign

Also i tried to play with some warm-blacky design: https://github.com/termitoz/qtpass/tree/Futurator-redesign-warm-blacky

@annejan

This comment has been minimized.

Member

annejan commented Jan 18, 2016

Nice!!

Will try and merge all this stuff tomorrow :)

@termitoz

This comment has been minimized.

termitoz commented Jan 19, 2016

updated icons etc... (blue variant)

@annejan

This comment has been minimized.

Member

annejan commented Jan 19, 2016

Merged in develop, now trying to cross-merge with futurator-redesign, will take some work though ;)

@annejan annejan removed the Linux label Jan 19, 2016

@annejan

This comment has been minimized.

Member

annejan commented Jan 19, 2016

Also TODO is detect wether or not system icons are available (not available on OSX at-least) . .

@annejan annejan referenced this pull request Jan 20, 2016

Closed

Improvements for the UI #143

@annejan

This comment has been minimized.

Member

annejan commented Jan 21, 2016

Back on topic of this pull request . .
screenshot_20160122_004108

It looks incredibly nice on KDE 5

@annejan

This comment has been minimized.

Member

annejan commented Jan 21, 2016

Unfortunately there are no system icons available on OSX, still looks pretty good . .
screen shot 2016-01-21 at 13 26 51
Same with Windows . .
mejuk

Which is not so much a problem as one can set a (local) iconset to use as fallback.
http://stackoverflow.com/questions/12299626/use-of-qt-standard-icons-from-within-qt-creator

@annejan

This comment has been minimized.

Member

annejan commented Jan 21, 2016

Gnome (Fedora default)
145338988231

@jsimplicio

This comment has been minimized.

jsimplicio commented Jan 21, 2016

@annejan Not sure if you saw my post in the UI improvements issue but I made some icons for the interface. Can we use our own icons?

qtpass

@annejan

This comment has been minimized.

Member

annejan commented Jan 21, 2016

Yes, we can @jsimplicio . .

I am currently looking into making it easy to theme though, since I know a lot of people like to have their system-wide icon theme . . and others prefer application specific.

I'm thinking of defaulting to system-wide icons when available and when not available use our own set.

Also a possibility to change colours from system default to application specific in a simple theming way (see screenshots from @termitoz )

With the redesign of the configuration screen and some more changes it should be relatively easy to make a theming system, where you can simply add a folder of png's and a configuration (ini) file. . .
Kind of like WinAmp of old 💃

Mostly because I want to keep the base-install clean and possibly provide bundled themes separately.

@jsimplicio

This comment has been minimized.

jsimplicio commented Jan 21, 2016

@annejan Got ya! Anyone started trying to redesign the config screen?

@annejan

This comment has been minimized.

Member

annejan commented Jan 21, 2016

Yes, @jsimplicio the Pull Request starter @jounathaen did a lot of work in that department . .
screen shot 2016-01-21 at 17 08 46
screen shot 2016-01-21 at 17 08 55
screen shot 2016-01-21 at 17 08 58
screen shot 2016-01-21 at 17 09 00
It's available in the develop branch by the way . .

@annejan

This comment has been minimized.

Member

annejan commented Jan 21, 2016

I'm looking to replace the stock_new-bcard icon though, since that one is barely available . .
http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html

But can't really find a good one 😢

@jsimplicio

This comment has been minimized.

jsimplicio commented Jan 21, 2016

@annejan looks better. Is there anything you need some help designing for? Or making these look better ?

@annejan

This comment has been minimized.

Member

annejan commented Jan 21, 2016

All forms of help are welcome, both in designing and just brainstorming.

For example, one thing we'll need pretty soon is to put more options into the profile's . .
Have some ideas but they all look way complex.

Also some more stuff that was mentioned in earlier issues.

PS. Is there a way for you to share the button set you designed for use on OSX and Windows (set of png's or svg's would be ideal).

@jsimplicio

This comment has been minimized.

jsimplicio commented Jan 21, 2016

@annejan Shared the icons in the UI improvements issue

@jsimplicio

This comment has been minimized.

jsimplicio commented Jan 21, 2016

@annejan You should share your ideas for the profiles

@annejan

This comment has been minimized.

Member

annejan commented Jan 21, 2016

@jsimplicio the discussion is in #112 git options should not be global options but maintainable per profile #112

Thanks for the round buttons, I'd really like to have "just the icons" too (as fallback for Win and OSX) for the merge of this pullrequest #124

@annejan annejan referenced this pull request Jan 22, 2016

Merged

Pre 1.1 mixing #145

@jsimplicio

This comment has been minimized.

jsimplicio commented Jan 22, 2016

@annejan Sorry you were in need of those icons pretty quick. I got your email. Was just busy. Will reply back soon. :)

@annejan

This comment has been minimized.

Member

annejan commented Jan 22, 2016

No worries :)
I'm not in need of them "that" quickly but I would love to have a new release #145 out this weekend 😄

Thanks again for all the hard work . .

@jsimplicio

This comment has been minimized.

jsimplicio commented Jan 22, 2016

@annejan By copy (password) icon do you mean a key?

@annejan

This comment has been minimized.

Member

annejan commented Jan 22, 2016

@jsimplicio either a key or a copy icon .. like .. two documents . . since that is what will be used on FreeDesktop compatible systems . .

@jsimplicio

This comment has been minimized.

jsimplicio commented Jan 22, 2016

@annejan Ah sorry I got that confused. I was just thinking of an old message here I saw a key icon

@annejan annejan merged commit a6b78b2 into IJHack:master Jan 22, 2016

0 of 2 checks passed

linthub Linthub has found some code style suggestions while reviewing the pull request.
Details
continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment