Skip to content
Permalink
Browse files Browse the repository at this point in the history
fixed bug #0021435
  • Loading branch information
alex40724 committed Oct 11, 2017
1 parent d9fe9b4 commit b2a4660
Showing 1 changed file with 32 additions and 1 deletion.
33 changes: 32 additions & 1 deletion Services/MediaObjects/classes/class.ilMediaItem.php
Expand Up @@ -671,7 +671,10 @@ function getHAlign()
*/
function setParameter($a_name, $a_value)
{
$this->parameters[$a_name] = $a_value;
if ($this->checkParameter($a_name, $a_value))
{
$this->parameters[$a_name] = $a_value;
}
}

/**
Expand Down Expand Up @@ -700,6 +703,34 @@ function setParameters($a_par)
}
}

/**
* Check parameter (filter javascript related and other unsafe parameters/values)
*
* @param string $a_par parameter
* @param string $a_val value
* @return bool
*/
function checkParameter($a_par, $a_val)
{
// do not allow event attributes
if (substr(strtolower(trim($a_par)), 0, 2) == "on")
{
return false;
}
// no javascript in value
if (is_int(strpos(strtolower($a_val), "javascript")))
{
return false;
}
// do not allow to change the src attribute
if (in_array(strtolower(trim($a_par)), array("src")))
{
return false;
}

return true;
}


/**
* get all parameters (in array)
Expand Down

0 comments on commit b2a4660

Please sign in to comment.