Deps: readd webui-popover (npm)#10081
Merged
fhelfer merged 1 commit intoSep 16, 2025
Merged
Conversation
fhelfer
added
dependencies
fhelfer
added
jour fixe
and removed
javascript
Member
|
Jour Fixe, 15 SEP 2025: Even though the library is no longer maintained, we accept the dependency for 11 and hope that we will find an alternative library for ILIAS 12. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit readds webui-popover v. 1.2.18 as npm dependency to ILIAS 11.
Usage
ILIAS/UI
Reasoning
The library is used to create popovers in the UI-framework. This applies to the initial Popover component, as well as to other components, such as Filters, Rating, that use the Popover component.
Maintenance
There are 26 contributors to the library. The last commit to the library is 9 years old, as well as the last released version. The last open issue is from Oct '21, as well as the last closed issue. Last closed PR is from 2023. The open issues seem to be either feature requests or rather specific bugs.
It seems as if the development of the library has stopped, be it because its feature complete, be it because interest vanished.
Links
Alternatives
There are plenty of alternatives to this library in the JS library space. Also, the HTML standard itself has gotten facilities to create popovers, although they are not enough to replace this library.
Assessment
This has already been a topic during the ILIAS 10 release (#8377), where the situation was essentially the same. As there is not enough time to search for and integrate a new library for the ILIAS 11 release, we will temporarily rely on this library again for this release to keep top maintain existing functionality.
The library has served us well for quite some time now. We most probably would not add it as a new library now, due to the state of its maintenance. It still seems to be reasonable to accept it for ILIAS 11 now, so we can move on with the release and testing. We should definitely look for alternatives for ILIAS 12, most probably a custom implementation for vanilla HTML/JS. Depending on the complexity of the new solution and the state of the ILIAS 11 release, we could then decide to replace the library.