fix: remove strict_types declaration from ilSoapObjectAdministration to restore SOAP compatibility (#0046688)#11599
Open
sKarki999 wants to merge 1 commit into
Open
Conversation
…to restore SOAP compatibility (#0046688)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://mantis.ilias.de/view.php?id=46688
Removes declare(strict_types=1) from ilSoapObjectAdministration.
Discussed on Mantis: https://mantis.ilias.de/view.php?id=46688, the conclusion was to revert, since a proper strict-type check would break several soap functions at this point and such changes should come through a development version in future releases.
There is inconsistency among versions. Currently, version 11 does not have the strict check. However, trunk has. I will provide the PR for trunk as well.