From 4032daadee9c55b0da36faf55b1a539fbf7b7575 Mon Sep 17 00:00:00 2001 From: Oscar Reyes Date: Sun, 22 Oct 2017 18:26:57 -0500 Subject: [PATCH 01/13] Changed '+' string concatenations to str format() --- filemanager/__init__.py | 110 +++++++++++----------------------------- 1 file changed, 30 insertions(+), 80 deletions(-) diff --git a/filemanager/__init__.py b/filemanager/__init__.py index f772cdd..3019576 100644 --- a/filemanager/__init__.py +++ b/filemanager/__init__.py @@ -62,21 +62,21 @@ def __init__( def rename_if_exists(self, folder, file): if folder[-1] != os.sep: folder = folder + os.sep - if os.path.exists(folder + file): + if os.path.exists("{}{}".format(folder, file)): if file.find('.') == -1: # no extension for i in range(1000): - if not os.path.exists(folder + file + '.' + str(i)): + if not os.path.exists("{}{}.{}".format(folder, file, str(i)): break - return file + '.' + str(i) + return "{}.{}".format(file, str(i) else: extension = file[file.rfind('.'):] name = file[:file.rfind('.')] for i in range(1000): - full_path = folder + name + '.' + str(i) + extension + full_path = "{}{}.{}{}".format(folder, name, str(i), extension) if not os.path.exists(full_path): break - return name + '.' + str(i) + extension + return "{}.{}{}".format(name, str(i), extension) else: return file @@ -106,7 +106,7 @@ def handle_form(self, form, files): and not re.match(r'[\w\d_ -]+', name).group(0) == name ) if invalid_folder_name: - messages.append("Invalid folder name : " + name) + messages.append("Invalid folder name : {}".format(name)) return messages invalid_file_name = ( @@ -118,12 +118,12 @@ def handle_form(self, form, files): ) ) if invalid_file_name: - messages.append("Invalid file name : " + name) + messages.append("Invalid file name : {}".format(name)) return messages invalid_path = not re.match(r'[\w\d_ -/]+', path).group(0) == path if invalid_path: - messages.append("Invalid path : " + path) + messages.append("Invalid path : {}".format(path)) return messages if action == 'upload': for f in files.getlist('ufile'): @@ -132,14 +132,9 @@ def handle_form(self, form, files): or not re.match('[\w\d_ -/.]+', f.name).group(0) == f.name ) if file_name_invalid: - messages.append("File name is not valid : " + f.name) + messages.append("File name is not valid : {}".format(f.name)) elif f.size > self.maxfilesize*1024: - messages.append( - "File size exceeded " - + str(self.maxfilesize) - + " KB : " - + f.name - ) + messages.append("File size exceeded {} KB : {}".format(str(self.maxfilesize), f.name)) elif ( settings.FILEMANAGER_CHECK_SPACE and ( @@ -147,39 +142,22 @@ def handle_form(self, form, files): > self.maxspace*1024 ) ): - messages.append( - "Total Space size exceeded " - + str(self.maxspace) - + " KB : " - + f.name - ) + messages.append("Total Space size exceeded {} KB: {}".format(str(self.maxspace), f.name)) elif ( self.extensions and len(f.name.split('.')) > 1 and f.name.split('.')[-1] not in self.extensions ): - messages.append( - "File extension not allowed (." - + f.name.split('.')[-1] - + ") : " - + f.name - ) + messages.append("File extension not allowed (.{}) : {}".format(f.name.split('.)[-1], f.name)) elif ( self.extensions and len(f.name.split('.')) == 1 and f.name.split('.')[-1] not in self.extensions ): - messages.append( - "No file extension in uploaded file : " - + f.name - ) + messages.append("No file extension in uploaded file: {}".format(f.name)) else: - filepath = ( - self.basepath - + path - + self.rename_if_exists(self.basepath + path, f.name) - ) + filepath = "{}{}{}".format(self.basepath, path, f.name") with open(filepath, 'w') as dest: for chunk in f.chunks(): dest.write(chunk) @@ -193,9 +171,9 @@ def handle_form(self, form, files): try: os.chdir(self.basepath + path) os.mkdir(name) - messages.append('Folder created successfully : ' + name) + messages.append('Folder created successfully : {}'.format(name)) except: - messages.append('Folder couldn\'t be created : ' + name) + messages.append('Folder couldn\'t be created : '.format(name)) else: messages.append( 'Folder couldn\' be created because maximum number of ' @@ -208,14 +186,9 @@ def handle_form(self, form, files): try: os.chdir(self.basepath + path) os.rename(oldname, name) - messages.append( - 'Folder renamed successfully from ' - + oldname - + ' to ' - + name - ) + messages.append('Folder renamed successfully from {} to {}'.format(oldname, name)) except: - messages.append('Folder couldn\'t renamed to ' + name) + messages.append('Folder couldn\'t renamed to {}'.format(name)) elif action == 'delete' and file_or_dir == 'dir': if path == '/': messages.append('root folder can\'t be deleted') @@ -225,9 +198,9 @@ def handle_form(self, form, files): try: os.chdir(self.basepath + path) shutil.rmtree(name) - messages.append('Folder deleted successfully : ' + name) + messages.append('Folder deleted successfully : {}'.format(name)) except: - messages.append('Folder couldn\'t deleted : ' + name) + messages.append('Folder couldn\'t deleted : {}'.format(name)) elif action == 'rename' and file_or_dir == 'file': oldname = path.split('/')[-1] old_ext = ( @@ -241,25 +214,14 @@ def handle_form(self, form, files): try: os.chdir(self.basepath + path) os.rename(oldname, name) - messages.append( - 'File renamed successfully from ' - + oldname - + ' to ' - + name - ) + messages.append('File renamed successfully from {} to {}'.format(oldname, name)) except: - messages.append('File couldn\'t be renamed to ' + name) + messages.append('File couldn\'t be renamed to {}'.format(name)) else: if old_ext: - messages.append( - 'File extension should be same : .' - + old_ext - ) + messages.append('File extension should be same : .{}'.format(old_ext)) else: - messages.append( - 'New file extension didn\'t match with old file' - + ' extension' - ) + messages.append('New file extension didn\'t match with old file extension') elif action == 'delete' and file_or_dir == 'file': if path == '/': messages.append('root folder can\'t be deleted') @@ -269,25 +231,18 @@ def handle_form(self, form, files): try: os.chdir(self.basepath + path) os.remove(name) - messages.append('File deleted successfully : ' + name) + messages.append('File deleted successfully : {}'.format(name)) except: - messages.append('File couldn\'t deleted : ' + name) + messages.append('File couldn\'t deleted : {}'.format(name)) elif action == 'move' or action == 'copy': # from path to current_path if self.current_path.find(path) == 0: messages.append('Cannot move/copy to a child folder') else: path = os.path.normpath(path) # strip trailing slash if any - filename = ( - self.basepath - + self.current_path - + os.path.basename(path) - ) + filename = ('{}{}{}'.format(self.basepath, self.current_path, os.pathname(path)) if os.path.exists(filename): - messages.append( - 'ERROR: A file/folder with this name already exists in' - + ' the destination folder.' - ) + messages.append('ERROR: A file/folder with this name already exists in the destination folder.') else: if action == 'move': method = shutil.move @@ -299,9 +254,7 @@ def handle_form(self, form, files): try: method(self.basepath + path, filename) except: - messages.append( - 'File/folder couldn\'t be moved/copied.' - ) + messages.append('File/folder couldn\'t be moved/copied.') return messages def directory_structure(self): @@ -371,10 +324,7 @@ def media(self, path): + '.png' ) if not os.path.exists(imagepath): - imagepath = ( - settings.FILEMANAGER_STATIC_ROOT - + 'images/icons/default.png' - ) + imagepath = ('{}images/icons/default.png'.format(settings.FILEMANAGER_STATIC_ROOT)) img = Image.open(imagepath) width, height = img.size mx = max([width, height]) From 0b687e91624eca8c1794080c572613a93d7e47ef Mon Sep 17 00:00:00 2001 From: Oscar Reyes Date: Sun, 22 Oct 2017 18:33:50 -0500 Subject: [PATCH 02/13] Changed " to ' --- filemanager/__init__.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/filemanager/__init__.py b/filemanager/__init__.py index 3019576..149b322 100644 --- a/filemanager/__init__.py +++ b/filemanager/__init__.py @@ -309,7 +309,7 @@ def media(self, path): w = width*60/mx h = height*60/mx img = img.resize((w, h), Image.ANTIALIAS) - response = HttpResponse(content_type=mimetype or "image/" + ext) + response = HttpResponse(content_type=mimetype or 'image/' + ext) response['Cache-Control'] = 'max-age=3600' img.save( response, @@ -333,7 +333,7 @@ def media(self, path): w = width*60/mx h = height*60/mx img = img.resize((w, h), Image.ANTIALIAS) - response = HttpResponse(content_type="image/png") + response = HttpResponse(content_type='image/png') response['Cache-Control'] = 'max-age:3600' img.save(response, 'png') return response From 25665c66a972c30af233037bb65ed85ac6684d36 Mon Sep 17 00:00:00 2001 From: Oscar Reyes Date: Sun, 22 Oct 2017 18:36:32 -0500 Subject: [PATCH 03/13] Changed " to ' Left " for docstrings --- filemanager/widgets.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/filemanager/widgets.py b/filemanager/widgets.py index 9f08282..a25624a 100644 --- a/filemanager/widgets.py +++ b/filemanager/widgets.py @@ -37,12 +37,12 @@ class Media: def render(self, name, value, attrs=None): rendered = super(CKEditorWidget, self).render(name, value, attrs) - div = "
" + div = '
' return rendered + mark_safe( div - + u"""""" % (attrs['id'], self.config) + ''' % (attrs['id'], self.config) ) From 4d05492689bd02337108862388fefed07134d826 Mon Sep 17 00:00:00 2001 From: Oscar Reyes Date: Sun, 22 Oct 2017 18:38:51 -0500 Subject: [PATCH 04/13] Changed str concatenation to format() --- filemanager/settings.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/filemanager/settings.py b/filemanager/settings.py index 24c55af..091336e 100644 --- a/filemanager/settings.py +++ b/filemanager/settings.py @@ -5,7 +5,7 @@ FILEMANAGER_STATIC_ROOT = getattr( settings, 'FILEMANAGER_STATIC_ROOT', - os.path.dirname(os.path.abspath(__file__)) + '/static/filemanager/', + os.path.dirname('{}/static/filemanager/'.format(os.path.abspath(__file__))), ) FILEMANAGER_CKEDITOR_JS = getattr( settings, From d0600af66253be517b2b48e6d609850f73f24f07 Mon Sep 17 00:00:00 2001 From: Oscar Reyes Date: Mon, 23 Oct 2017 05:11:03 -0500 Subject: [PATCH 05/13] Fixed single quotes inside single quotes. --- filemanager/widgets.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/filemanager/widgets.py b/filemanager/widgets.py index a25624a..a89ebd6 100644 --- a/filemanager/widgets.py +++ b/filemanager/widgets.py @@ -37,7 +37,7 @@ class Media: def render(self, name, value, attrs=None): rendered = super(CKEditorWidget, self).render(name, value, attrs) - div = '
' + div = "
" return rendered + mark_safe( div + u'''