New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple tag filtering #31

Closed
wants to merge 2 commits into
base: neurostars.org
from

Conversation

Projects
None yet
2 participants
@puntonim

puntonim commented Mar 16, 2014

A simple fix to hide pill bar in case of anonymous user
This doesn't fix the following urls:
http://neurostars.org/show/messages/
http://neurostars.org/show/myvotes/
http://neurostars.org/show/mybookmarks/
http://neurostars.org/show/myposts/

But the only way to get to those pages now is by typing them

puntonim added some commits Mar 16, 2014

Multiple tag filtering
Add multiple tag filtering feature: a sequence of clicks on different tags generates an exclusive
tag filter.
So if a user first clicks on 'mapping' and then on 'conversion' the generated filter is something
like: tag = 'mapping' OR 'conversion'.
I chose OR as default operator because that was already implemented in query_by_tags
method (models.py file).
@puntonim

This comment has been minimized.

Show comment
Hide comment
@puntonim

puntonim Mar 16, 2014

Note: The second commit "Multiple tag filtering" should have been in a new pull request, bit it has sneaked here.

Clicking sequentially on different tags generates an exclusive tag filter.
It is implemented by concatenating tags in the url, see attached pic:
untitled

It is a simple way to add multiple tag filtering feature to neurostars.org, as suggested in your GSoC 1024 proposal. I did it in order to get to know the codebase. You don't really have to merge this pull request right now, I haven't tested it that much yet.

puntonim commented Mar 16, 2014

Note: The second commit "Multiple tag filtering" should have been in a new pull request, bit it has sneaked here.

Clicking sequentially on different tags generates an exclusive tag filter.
It is implemented by concatenating tags in the url, see attached pic:
untitled

It is a simple way to add multiple tag filtering feature to neurostars.org, as suggested in your GSoC 1024 proposal. I did it in order to get to know the codebase. You don't really have to merge this pull request right now, I haven't tested it that much yet.

@brainstorm

This comment has been minimized.

Show comment
Hide comment
@brainstorm

brainstorm Mar 16, 2014

Member

@nimiq, Thanks for the pull request and the detailed description of the improvement! As you said I will not merge it now, but please make sure you mention this on your application on Melange :)

Member

brainstorm commented Mar 16, 2014

@nimiq, Thanks for the pull request and the detailed description of the improvement! As you said I will not merge it now, but please make sure you mention this on your application on Melange :)

@brainstorm brainstorm added the GSoC2014 label May 19, 2014

@brainstorm brainstorm changed the title from Issue #30 - Personal pages for anonymous users to Multiple tag filtering Jun 19, 2014

@brainstorm

This comment has been minimized.

Show comment
Hide comment
@brainstorm

brainstorm Jun 19, 2014

Member

Multiple tag filtering scheduled for next week as discussed. Changing name of the issue.

Member

brainstorm commented Jun 19, 2014

Multiple tag filtering scheduled for next week as discussed. Changing name of the issue.

@puntonim

This comment has been minimized.

Show comment
Hide comment
@puntonim

puntonim commented Jun 25, 2014

Done here: ialbert#244

@puntonim puntonim closed this Jun 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment