Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Tag' targeting on tag archive pages #74

Merged
merged 1 commit into from Oct 17, 2018
Merged

Add 'Tag' targeting on tag archive pages #74

merged 1 commit into from Oct 17, 2018

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Oct 17, 2018

Changes

  • Adds 'Tag' targeting on tag archive pages

Why

Closes #29, fixing a feature difference between tags and categories, since after #72 we had "Category" targeting for category archives.

Testing/Questions

  1. Create a tag.
  2. Go to the tag archive page.
  3. Search source code for "targeting" and verify that the JSON contains the tag.

@benlk benlk added this to the 0.3 milestone Oct 17, 2018
@benlk benlk merged commit 8f92c75 into master Oct 17, 2018
@benlk benlk deleted the 29-tag-targeting branch October 17, 2018 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Targeting options don't set the 'Category' targeting for category archive pages
1 participant