New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenberg Support #82
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… logging for everybody.
… why. Something with scope.
…es on the plugin. What doesn't work: - The edit form needs to regenerate them by clicking onto another block and then clicking back in. - The sizes aren't saved to the DB.
A follow-up to my comments on c23f4e3: - The `save` function is working as intended. When the post is saved, whatever the attributes currently are are written to the database. - The `edit` function is still acting up. In order to display updated attributes, you have to get the edit function to rerun, which is most-easily done by clicking on another block and then back on this one.
…rray by making it s JSONified string. Things that helped here: - WordPress/gutenberg#7242 - WordPress/gutenberg#6097 - WordPress/gutenberg#6074
And remove debugging code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Why
For #70
Testing/Questions
Questions that need to be answered before merging:
Steps to test this PR: