Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg Support #82

Merged
merged 23 commits into from Nov 2, 2018
Merged

Gutenberg Support #82

merged 23 commits into from Nov 2, 2018

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Oct 31, 2018

Changes

  • adds gutenblock, with settings options for:
    • identifier (in main block in editor)
    • lazyload
    • sizes
    • customClassName
    • align
    • alignwide
  • slight changes to PR template to save keystrokes.

screen shot 2018-11-01 at 8 15 23 pm

Why

For #70

Testing/Questions

Questions that need to be answered before merging:

  • does it work in 4.9.8?
  • does it work in 5.0-beta2?
  • do widgets still work?
  • does the widget accept the alignment properties?

Steps to test this PR:

  1. Install plugin
  2. Configure the plugin's breakpoints.
  3. In a post, add a block!
  4. Configure the block's sizes at its breakpoints
  5. Configure the block's ad unit code
  6. Set an alignment and check that that's respected.

@benlk benlk added this to the 0.3 milestone Oct 31, 2018
@benlk benlk self-assigned this Oct 31, 2018
…es on the plugin.

What doesn't work:
- The edit form needs to regenerate them by clicking onto another block and then clicking back in.
- The sizes aren't saved to the DB.
A follow-up to my comments on c23f4e3:

- The `save` function is working as intended. When the post is saved, whatever the attributes currently are are written to the database.
- The `edit` function is still acting up. In order to display updated attributes, you have to get the edit function to rerun, which is most-easily done by clicking on another block and then back on this one.
@benlk benlk merged commit dd7380f into master Nov 2, 2018
@benlk benlk deleted the 70-gutenberg branch November 2, 2018 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant