New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break apart /less/inc/widgets.less into per-widget files #882
Conversation
…iles to the Grunt watch task, and clean up a little
List of widget classes and ids, for the search: .largo-about
.largo-author
.author-box
.largo-disclaimer
.largo-donate
.largo-explore-related
#related-posts
#related-post-nav
#related-items
.largo-facebook
.fb-like-box
.largo-featured
.largo-follow
.largo-footer-featured
.widget_sp_image
.largo-INN-RSS
.largo-post-series-links
.largo-prev-next-post-links
.previous
.next
.largo-recent-comments
.recentcomments
.comment-excerpt
.comment-meta
.largo-recent-posts
.largo-related-posts
ul.related
.largo-series-posts
h4
.largo-sidebar-featured
.largo_staff_widget
ul.staff-roster
span.staff-name
.largo-tag-list
.tags
.largo-taxonomy-list
select.taxonomy-list-widget
.largo-twitter
a.twitter-timeline |
This seems like a solid start but I'm not 100% sold on the need for the empty files. I'd say we should probably just create separate files for the widgets that actually have those more narrowly scoped styles associated with them and try, as much as possible, to just use the defaults wherever possible and override things only very selectively. |
I agree with you on the totally-empty files, but I think we should keep empty files for the comments when there are more-narrowly-scoped styles specific to that widget that are kept in a different file to reduce code duplication. |
Hm. Maybe. I think it makes sense to do that sometimes. Like, if there's a reasonably likely chance that a developer working on this would be confused, then thumbs up. If it's just a placeholder, then probably not necessary. |
I guess the question is: What would cause confusion? If someone's looking at per-widget LESS files, they probably wouldn't look for styles concerning the INN Member Stories widget in If someone's looking at If someone's looking at the sourcemaps in a browser, they're going to see the correct file, and won't ever see the empty file, so I don't think the empties will cause confusion. |
This now has the empty files removed. |
Break apart /less/inc/widgets.less into per-widget files
Changes
/less/inc
Why
To clean up widgets.less, for #880
To Do