New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: CtFormalTypeDeclarer extends CtTypeMember #1235

Merged
merged 1 commit into from Mar 22, 2017

Conversation

Projects
None yet
3 participants
@pvojtechovsky
Collaborator

pvojtechovsky commented Mar 20, 2017

What about this small change in spoon model?

@monperrus

This comment has been minimized.

Show comment
Hide comment
@monperrus

monperrus Mar 20, 2017

Collaborator

what's the purpose?

Collaborator

monperrus commented Mar 20, 2017

what's the purpose?

@pvojtechovsky

This comment has been minimized.

Show comment
Hide comment
@pvojtechovsky

pvojtechovsky Mar 20, 2017

Collaborator

The code which collects formal type arguments of declaring types is little bit simpler if CtFormalTypeDeclarer extends CtTypeMember, because it is so. CtFormalTypeDeclarer already extends CtFormalTypeDeclarer, but it is not declared in model.

But if you have any reason why it is not good idea then close this PR. I have no problem with that.

Collaborator

pvojtechovsky commented Mar 20, 2017

The code which collects formal type arguments of declaring types is little bit simpler if CtFormalTypeDeclarer extends CtTypeMember, because it is so. CtFormalTypeDeclarer already extends CtFormalTypeDeclarer, but it is not declared in model.

But if you have any reason why it is not good idea then close this PR. I have no problem with that.

@monperrus

This comment has been minimized.

Show comment
Hide comment
@monperrus

monperrus Mar 21, 2017

Collaborator
Collaborator

monperrus commented Mar 21, 2017

@pvojtechovsky

This comment has been minimized.

Show comment
Hide comment
@pvojtechovsky

pvojtechovsky Mar 21, 2017

Collaborator

That all existing implementations of CtFormalTypeDeclarer already implements CtTypeMember

Collaborator

pvojtechovsky commented Mar 21, 2017

That all existing implementations of CtFormalTypeDeclarer already implements CtTypeMember

@monperrus

This comment has been minimized.

Show comment
Hide comment
@monperrus

monperrus Mar 21, 2017

Collaborator
Collaborator

monperrus commented Mar 21, 2017

@msteinbeck

This comment has been minimized.

Show comment
Hide comment
@msteinbeck

msteinbeck Mar 21, 2017

Contributor

look good to me

Contributor

msteinbeck commented Mar 21, 2017

look good to me

@monperrus monperrus merged commit f190d8e into INRIA:master Mar 22, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 81.059%
Details
pull_request-INRIA-spoon-master-docker /tmp/tmpf7l2g7_c
Details
pull_request-INRIA-spoon-master-revapi Revapi: No change detected.
Details

@pvojtechovsky pvojtechovsky deleted the pvojtechovsky:FormalTypeDeclarerAsTypeMember branch Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment