New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: refactor MethodTypingContext#isOverriding moved to ClassTypingContext #1299

Merged
merged 2 commits into from May 15, 2017

Conversation

Projects
None yet
3 participants
@pvojtechovsky
Collaborator

pvojtechovsky commented May 15, 2017

Possible solution of #1292

@spoon-bot

This comment has been minimized.

Show comment
Hide comment
@spoon-bot

spoon-bot May 15, 2017

Collaborator

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-20170514.224530-96

New API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-SNAPSHOT

Detected changes: 3.

Change 1

Name Element
Old method boolean spoon.support.visitor.MethodTypingContext::isOverriding(spoon.reflect.declaration.CtMethod<?>)
New none
Code java.method.removed
Description Method was removed.
Breaking source: breaking,

Change 2

Name Element
Old method boolean spoon.support.visitor.MethodTypingContext::isSameSignature(spoon.reflect.declaration.CtMethod<?>)
New none
Code java.method.removed
Description Method was removed.
Breaking source: breaking,

Change 3

Name Element
Old method boolean spoon.support.visitor.MethodTypingContext::isSubSignature(spoon.reflect.declaration.CtMethod<?>)
New none
Code java.method.removed
Description Method was removed.
Breaking source: breaking,
Collaborator

spoon-bot commented May 15, 2017

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-20170514.224530-96

New API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-SNAPSHOT

Detected changes: 3.

Change 1

Name Element
Old method boolean spoon.support.visitor.MethodTypingContext::isOverriding(spoon.reflect.declaration.CtMethod<?>)
New none
Code java.method.removed
Description Method was removed.
Breaking source: breaking,

Change 2

Name Element
Old method boolean spoon.support.visitor.MethodTypingContext::isSameSignature(spoon.reflect.declaration.CtMethod<?>)
New none
Code java.method.removed
Description Method was removed.
Breaking source: breaking,

Change 3

Name Element
Old method boolean spoon.support.visitor.MethodTypingContext::isSubSignature(spoon.reflect.declaration.CtMethod<?>)
New none
Code java.method.removed
Description Method was removed.
Breaking source: breaking,

@pvojtechovsky pvojtechovsky changed the title from refactor MethodTypingContext#isOverriding moved to ClassTypingContext to review: refactor MethodTypingContext#isOverriding moved to ClassTypingContext May 15, 2017

@monperrus monperrus merged commit 0743b5a into INRIA:master May 15, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.04%) to 81.464%
Details
pull_request-INRIA-spoon-master-docker exec in /tmp/tmpg6ua_f6r
Details
pull_request-INRIA-spoon-master-revapi exec in /tmp/tmpvsgw9faf
Details

@pvojtechovsky pvojtechovsky deleted the pvojtechovsky:ref3Methods branch May 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment