New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove deprecated computeImports #1234 #1311

Merged
merged 2 commits into from May 19, 2017

Conversation

Projects
None yet
3 participants
@surli
Collaborator

surli commented May 19, 2017

No description provided.

@surli surli changed the title from Remove deprecated computeImports #1234 to refactor: Remove deprecated computeImports #1234 May 19, 2017

@@ -34,7 +34,7 @@
*
* @return class imports computed by Spoon, it does not contain static imports
*/
Collection<CtTypeReference<?>> computeImports(CtType<?> simpleType);
Collection<CtTypeReference<?>> computeImports(CtElement element);

This comment has been minimized.

@monperrus

monperrus May 19, 2017

Collaborator

update javadoc?

@monperrus

monperrus May 19, 2017

Collaborator

update javadoc?

@spoon-bot

This comment has been minimized.

Show comment
Hide comment
@spoon-bot

spoon-bot May 19, 2017

Collaborator

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-20170519.124302-108

New API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-SNAPSHOT

Detected changes: 2.

Change 1

Name Element
Old method void spoon.reflect.visitor.ImportScanner::computeImports(spoon.reflect.declaration.CtElement)
New none
Code java.method.removed
Description Method was removed.
Breaking source: breaking,

Change 2

Name Element
Old parameter java.util.Collection<spoon.reflect.reference.CtTypeReference> spoon.reflect.visitor.ImportScanner::computeImports(===spoon.reflect.declaration.CtType===)
New parameter java.util.Collection<spoon.reflect.reference.CtTypeReference<?>> spoon.reflect.visitor.ImportScanner::computeImports(===spoon.reflect.declaration.CtElement===)
Code java.method.parameterTypeChanged
Description The type of the parameter changed from 'spoon.reflect.declaration.CtType<?>' to 'spoon.reflect.declaration.CtElement'.
Breaking source: potentially_breaking,
Collaborator

spoon-bot commented May 19, 2017

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-20170519.124302-108

New API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-SNAPSHOT

Detected changes: 2.

Change 1

Name Element
Old method void spoon.reflect.visitor.ImportScanner::computeImports(spoon.reflect.declaration.CtElement)
New none
Code java.method.removed
Description Method was removed.
Breaking source: breaking,

Change 2

Name Element
Old parameter java.util.Collection<spoon.reflect.reference.CtTypeReference> spoon.reflect.visitor.ImportScanner::computeImports(===spoon.reflect.declaration.CtType===)
New parameter java.util.Collection<spoon.reflect.reference.CtTypeReference<?>> spoon.reflect.visitor.ImportScanner::computeImports(===spoon.reflect.declaration.CtElement===)
Code java.method.parameterTypeChanged
Description The type of the parameter changed from 'spoon.reflect.declaration.CtType<?>' to 'spoon.reflect.declaration.CtElement'.
Breaking source: potentially_breaking,

@monperrus monperrus merged commit 9b69b9c into INRIA:master May 19, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 81.615%
Details
pull_request-INRIA-spoon-master-docker exec in /tmp/tmphibs9w5z
Details
pull_request-INRIA-spoon-master-revapi exec in /tmp/tmphwz78hvj
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment