New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review bug: some Override annotations are retrieved without information by JDT #1312

Merged
merged 2 commits into from May 19, 2017

Conversation

Projects
None yet
2 participants
@surli
Collaborator

surli commented May 19, 2017

In some anonymous inner classes, in noClassPath, JDT does not provide information about Override annotation: by default the ReferenceBuilder assume that if a type does not have any import and has no package, it belongs to the current package.
So I added a check to verify if the current type belongs to the java.lang package.
Fix #1307

@monperrus monperrus merged commit cdd2acb into INRIA:master May 19, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 81.662%
Details
pull_request-INRIA-spoon-master-docker exec in /tmp/tmp7whfbx9y
Details
pull_request-INRIA-spoon-master-revapi no API change
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment