New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: replace string literals by constants #1316

Merged
merged 1 commit into from May 21, 2017

Conversation

Projects
None yet
2 participants
@pvojtechovsky
Collaborator

pvojtechovsky commented May 20, 2017

replaces all "" by CtExecutableReference.CONSTRUCTOR_NAME.
replaces all "lambda$" by CtExecutableReference.LAMBDA_NAME_PREFIX.

@pvojtechovsky pvojtechovsky changed the title from replace string literals by constants to review: replace string literals by constants May 20, 2017

@pvojtechovsky

This comment has been minimized.

Show comment
Hide comment
@pvojtechovsky

pvojtechovsky May 21, 2017

Collaborator

May be the constants are not on good place.
CtConstructor.CONSTRUCTOR_NAME
CtLambda.LAMBDA_NAME_PREFIX
might be better... We must of course keep legacy CtExecutableReference constant too.
WDYT?

The reason for this PR is that I need lambda name prefix constant in new spoon code.

Collaborator

pvojtechovsky commented May 21, 2017

May be the constants are not on good place.
CtConstructor.CONSTRUCTOR_NAME
CtLambda.LAMBDA_NAME_PREFIX
might be better... We must of course keep legacy CtExecutableReference constant too.
WDYT?

The reason for this PR is that I need lambda name prefix constant in new spoon code.

@monperrus monperrus merged commit d0d3f65 into INRIA:master May 21, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 81.683%
Details
pull_request-INRIA-spoon-master-docker exec in /tmp/tmpu678ba4s
Details
pull_request-INRIA-spoon-master-revapi no API change
Details

@pvojtechovsky pvojtechovsky deleted the pvojtechovsky:refStringLiterals branch May 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment